Skip to content

Commit ec4334a

Browse files
committed
Don't show a notice when no action has been taken.
1 parent 7169aec commit ec4334a

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

src/inc/generator.php

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ function ableplayer_generator_fields( $data ) {
132132
if ( $data && is_array( $data ) ) {
133133
$params = $data;
134134
}
135-
$message = isset( $params['message'] ) ? $params['message'] : __( 'Generate an <code>[ableplayer]</code> shortcode.', 'ableplayer' );
135+
$message = isset( $params['message'] ) ? $params['message'] : '';
136136
$message_type = isset( $params['type'] ) ? $params['type'] : 'info';
137137
$shortcode = isset( $params['shortcode'] ) ? $params['shortcode'] : '[ableplayer]';
138138
$last_shortcode = ableplayer_get_settings( 'last_shortcode' );
@@ -148,13 +148,15 @@ function ableplayer_generator_fields( $data ) {
148148
<div id="ableplayer-generator" class="generator">
149149
<div class="ableplayer-generator-data">
150150
<?php
151-
wp_admin_notice(
152-
$message,
153-
array(
154-
'type' => $message_type,
155-
'additional_classes' => array( 'inline' ),
156-
)
157-
);
151+
if ( $message ) {
152+
wp_admin_notice(
153+
$message,
154+
array(
155+
'type' => $message_type,
156+
'additional_classes' => array( 'inline' ),
157+
)
158+
);
159+
}
158160
?>
159161
<div><input type="hidden" name="_wpnonce" value="<?php echo esc_attr( wp_create_nonce( 'ableplayer-nonce' ) ); ?>"/></div>
160162
<?php

0 commit comments

Comments
 (0)