wasm2c from binaryen conflicts with wasm2c from wabt

[rathann]

The newly added (#8763) wasm2c tool introduces a conflict with wabt's wasm2c, which would prevent both packages from being installed at the same time on Fedora (and I have another package that requires both to build).

Are these two wasm2c supposed to be drop-in replacements and compatible? If not, can you rename one of them?

[kripken]

cc @lexi-nadia @tlively

There is some ongoing debate about the future of these tools, so maybe this is moot or will be.

But isn't the usual practice to rename on the distro side? (e.g. binaryen-wasm2c or byn-wasm2c for the fedora package)

[rathann]

cc @lexi-nadia @tlively

There is some ongoing debate about the future of these tools, so maybe this is moot or will be.

Alright, thanks for your consideration.

But isn't the usual practice to rename on the distro side? (e.g. binaryen-wasm2c or byn-wasm2c for the fedora package)

It is and I'm going to do that. For now, I'm more concerned that at least one lit test fails on i686, but I'll open a separate issue for that.

[robertkirkman]

sharing what I am doing, this is for people who are using the classically controversial command sudo make install or logical equivalents to or approximations of it, so that their wabt wasm2c does not get erased.

--- a/src/tools/wasm2c/CMakeLists.txt
+++ b/src/tools/wasm2c/CMakeLists.txt
@@ -10,6 +10,6 @@ set(WASM2C_TEMPLATE_SOURCES
     ${PREBUILT_DIR}/wasm2c_spec_top.cpp
 )
 
-binaryen_add_executable(wasm2c "wasm2c-builder.cpp;assertion-emitter.cpp;wasm2c.cpp;${WASM2C_TEMPLATE_SOURCES}")
+binaryen_add_executable(binaryen-wasm2c "wasm2c-builder.cpp;assertion-emitter.cpp;wasm2c.cpp;${WASM2C_TEMPLATE_SOURCES}")
 # TODO: https://github.com/WebAssembly/binaryen/issues/8775 - stop using picosha2
-target_include_directories(wasm2c PRIVATE ${PROJECT_SOURCE_DIR}/third_party/picosha2 ${PROJECT_SOURCE_DIR}/src/tools/wasm2c)
+target_include_directories(binaryen-wasm2c PRIVATE ${PROJECT_SOURCE_DIR}/third_party/picosha2 ${PROJECT_SOURCE_DIR}/src/tools/wasm2c)

[tlively]

Since Binaryen's wasm2c is still very much under construction, it might also make sense to make building it opt-in in the cmake config. I would be happy to accept a PR making that change.