Skip to content

Ghidra plugin import still shows comments and user types from an unanalyzed Ghidra file #8432

Description

@Weitao-Sun

Version and Platform (required):

  • Binary Ninja Version: 6.0.10474-dev Ultimate (c9ea4d90) (also present since 5.3.9757 stable)
  • Edition: Ultimate
  • OS: Windows 11 Pro
  • OS Version: 10.0.26200 (Build 26200)
  • CPU Architecture: x64 (AMD64 Family 25 Model 97, running under QEMU/Proxmox virtualization)

Bug Description:
When opening a file in Ghidra and declining analysis (selecting "No" on the analysis prompt shown on import), then adding comments and user types to the unanalyzed file, importing that same file into Binary Ninja via the Ghidra plugin still shows the added comments and user types. Since the file was never analyzed in Ghidra, these comments and user types should not be present/importable.

This issue also reproduce on stable version 5.3.9757

Steps To Reproduce:

  1. Open a binary in Ghidra
  2. When prompted to analyze the file, select "No"
  3. On the unanalyzed file, add one or more comments and one or more user types
  4. In Binary Ninja, use the Ghidra plugin to import the same file
  5. Observe that the comments added in Ghidra are visible in the Binary View
  6. Observe that the user types added in Ghidra are visible in the Types panel

Expected Behavior:
Since the file was not analyzed in Ghidra, the comments and user types added to it should not be imported/visible in Binary Ninja after using the Ghidra plugin import.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions