Skip to content

Commit 4e99def

Browse files
agviegasclaude
andcommitted
fix: type ItemsData placeholder row + dedupe @thatopen/components
The cycle-safe placeholder added in 4fa0615 was inferred as a plain object literal, widening `type: "item"` to `string` and breaking tsc. Annotate the placeholder as `BUI.TableGroupData<ItemsDataTableData>` so the literal type is preserved. Also dedupe `@thatopen/components` in yarn.lock: the bumps in cdedacb left two parallel resolutions (^3.4.5 -> 3.4.5 and ~3.4.0 -> 3.4.1), which installed a nested copy under @thatopen/components-front and broke type identity for Highlighter, RendererWith2D, and Components across the obc build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 650c15c commit 4e99def

2 files changed

Lines changed: 4 additions & 30 deletions

File tree

packages/obc/src/components/tables/ItemsData/src/template.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,15 @@ const getItemRow = (
5252
: category ?? String(localId);
5353

5454
if (modelProcessings.has(localId)) {
55-
return {
55+
const placeholder: BUI.TableGroupData<ItemsDataTableData> = {
5656
data: {
5757
modelId,
5858
localId,
5959
type: "item",
6060
Name: displayName,
6161
},
6262
};
63+
return placeholder;
6364
}
6465

6566
const row: BUI.TableGroupData<ItemsDataTableData> = {

yarn.lock

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ __metadata:
782782
languageName: node
783783
linkType: hard
784784

785-
"@thatopen/components@npm:^3.4.5":
785+
"@thatopen/components@npm:^3.4.5, @thatopen/components@npm:~3.4.0":
786786
version: 3.4.5
787787
resolution: "@thatopen/components@npm:3.4.5"
788788
dependencies:
@@ -798,22 +798,6 @@ __metadata:
798798
languageName: node
799799
linkType: hard
800800

801-
"@thatopen/components@npm:~3.4.0":
802-
version: 3.4.1
803-
resolution: "@thatopen/components@npm:3.4.1"
804-
dependencies:
805-
fast-xml-parser: 5.3.7
806-
jszip: 3.10.1
807-
three-mesh-bvh: 0.9.9
808-
peerDependencies:
809-
"@thatopen/fragments": ~3.4.0
810-
camera-controls: ">=3.1.2"
811-
three: ">=0.182.0"
812-
web-ifc: ">=0.0.77"
813-
checksum: 786e0397b7a2db42d5cd03c9774674dc410a80d658b3d4c11e731f2c8697e9d93de9b99af624bb3643a29277b5f4e48e0acb63ef7e34995619180d8061726985
814-
languageName: node
815-
linkType: hard
816-
817801
"@thatopen/fragments@npm:^3.4.5":
818802
version: 3.4.5
819803
resolution: "@thatopen/fragments@npm:3.4.5"
@@ -2411,17 +2395,6 @@ __metadata:
24112395
languageName: node
24122396
linkType: hard
24132397

2414-
"fast-xml-parser@npm:5.3.7":
2415-
version: 5.3.7
2416-
resolution: "fast-xml-parser@npm:5.3.7"
2417-
dependencies:
2418-
strnum: ^2.1.2
2419-
bin:
2420-
fxparser: src/cli/cli.js
2421-
checksum: 0bb307bc63a01c079ae28b6b62eeea0007d787e6ab47dfca493f40305f78aeedea2906b2632bf0eb9d4d868e748c77c70393a808441fb5949c9d2e6f8f2825f0
2422-
languageName: node
2423-
linkType: hard
2424-
24252398
"fast-xml-parser@npm:5.7.2":
24262399
version: 5.7.2
24272400
resolution: "fast-xml-parser@npm:5.7.2"
@@ -4784,7 +4757,7 @@ __metadata:
47844757
languageName: node
47854758
linkType: hard
47864759

4787-
"strnum@npm:^2.1.2, strnum@npm:^2.2.3":
4760+
"strnum@npm:^2.2.3":
47884761
version: 2.2.3
47894762
resolution: "strnum@npm:2.2.3"
47904763
checksum: e8deb0dd6f40e4a878bdd4404bdfdd47922665fcaaf27f2b345013b30d45d86f4b93d99cbc005bfb7c96edef6173369bd76a9df40bb7758850b7864075a28156

0 commit comments

Comments
 (0)