Commit 8a02b88
authored
feat: Syntax Highlighting for Multiline Editor (#1919)
## Description
Adds the option for syntax highlighting to the multiline texteditor via the new `highlightSyntax` prop.
When `true` it will render a select box for the user to choose a syntax language for highlighting purposes.
If the user selects `plaintext` the current vanilla `TextArea` component will render. If the user selects one of the provided code languages the Monaco Editor will render inside the dialog with syntax highlighting appropriate for that language.
This feature is currently implemented in all instances of the `MultilineTextInputDialog` though it is debateable if it has use for the Annotation Editor.
## Related Issue and Pull requests
Progresses #1891
Progresses Shopify/oasis-frontend#391
<!-- Link to any related issues using the format #<issue-number> -->
## Type of Change
<!-- Please delete options that are not relevant -->
- [x] Improvement
## Checklist
<!-- Please ensure the following are completed before submitting the PR -->
- [ ] I have tested this does not break current pipelines / runs functionality
- [ ] I have tested the changes on staging
## Screenshots (if applicable)
<!-- Include any screenshots that might help explain the changes or provide visual context -->
Before

After


Demo:
[syntax-highlighting-opt1.mov <span class="graphite__hidden">(uploaded via Graphite)</span> <img class="graphite__hidden" src="https://app.graphite.com/user-attachments/thumbnails/7b8f965b-d621-46b3-83a1-dfb3d0619b19.mov" />](https://app.graphite.com/user-attachments/video/7b8f965b-d621-46b3-83a1-dfb3d0619b19.mov)
## Test Instructions
Confirm that the multiline text editor now renders a select box and that changing the language renders the code viewer and appropriately highlights syntax.
<!-- Detail steps and prerequisites for testing the changes in this PR -->
## Additional Comments
<!-- Add any additional context or information that reviewers might need to know regarding this PR -->1 parent 28d89a1 commit 8a02b88
6 files changed
Lines changed: 97 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
Lines changed: 66 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
15 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
16 | 34 | | |
17 | 35 | | |
18 | 36 | | |
| |||
21 | 39 | | |
22 | 40 | | |
23 | 41 | | |
| 42 | + | |
24 | 43 | | |
25 | 44 | | |
26 | 45 | | |
| |||
33 | 52 | | |
34 | 53 | | |
35 | 54 | | |
| 55 | + | |
36 | 56 | | |
37 | 57 | | |
38 | 58 | | |
39 | 59 | | |
| 60 | + | |
40 | 61 | | |
41 | 62 | | |
42 | 63 | | |
| |||
61 | 82 | | |
62 | 83 | | |
63 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
64 | 89 | | |
65 | 90 | | |
66 | 91 | | |
67 | 92 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
80 | 134 | | |
81 | 135 | | |
82 | 136 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
| 412 | + | |
412 | 413 | | |
413 | 414 | | |
414 | 415 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
0 commit comments