Skip to content

Commit 688c1db

Browse files
committed
Add filter badge key to active filters badge
1 parent 2127fd1 commit 688c1db

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

src/components/shared/PipelineRunFiltersBar/PipelineRunFiltersBar.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ function isValidSortField(value: string): value is SortField {
5050

5151
const MAX_VISIBLE_BADGES = 4;
5252

53+
type FilterBadgeKey =
54+
| "status"
55+
| "pipeline_name"
56+
| "created_by"
57+
| "date_range"
58+
| `annotation-${number}`;
59+
5360
interface PipelineRunFiltersBarProps {
5461
totalCount?: number;
5562
filteredCount?: number;
@@ -111,7 +118,7 @@ export function PipelineRunFiltersBar({
111118

112119
// Build list of all active filter badges
113120
const allBadges: Array<{
114-
key: string;
121+
key: FilterBadgeKey;
115122
label: string;
116123
onRemove: () => void;
117124
}> = [];
@@ -126,7 +133,7 @@ export function PipelineRunFiltersBar({
126133

127134
if (filters.pipeline_name) {
128135
allBadges.push({
129-
key: "name",
136+
key: "pipeline_name",
130137
label: `Name: ${filters.pipeline_name}`,
131138
onRemove: () => {
132139
setFilter("pipeline_name", undefined);
@@ -153,7 +160,7 @@ export function PipelineRunFiltersBar({
153160
const separator = fromStr && toStr ? " – " : "";
154161

155162
allBadges.push({
156-
key: "date",
163+
key: "date_range",
157164
label: `${fromStr}${separator}${toStr}`,
158165
onRemove: () =>
159166
setFilters({ created_after: undefined, created_before: undefined }),

0 commit comments

Comments
 (0)