Skip to content

Commit 0b32ceb

Browse files
committed
Add filter badge key to active filters badge
1 parent b190058 commit 0b32ceb

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

src/components/shared/PipelineRunFiltersBar/PipelineRunFiltersBar.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ function isValidSortField(value: string): value is SortField {
5050

5151
const MAX_VISIBLE_BADGES = 4;
5252

53+
type FilterBadgeKey =
54+
| "status"
55+
| "pipeline_name"
56+
| "created_by"
57+
| "date_range"
58+
| `annotation-${number}`;
59+
5360
interface PipelineRunFiltersBarProps {
5461
totalCount?: number;
5562
filteredCount?: number;
@@ -113,7 +120,7 @@ export function PipelineRunFiltersBar({
113120

114121
// Build list of all active filter badges
115122
const allBadges: Array<{
116-
key: string;
123+
key: FilterBadgeKey;
117124
label: string;
118125
onRemove: () => void;
119126
}> = [];
@@ -128,7 +135,7 @@ export function PipelineRunFiltersBar({
128135

129136
if (filters.pipeline_name) {
130137
allBadges.push({
131-
key: "name",
138+
key: "pipeline_name",
132139
label: `Name: ${filters.pipeline_name}`,
133140
onRemove: () => {
134141
setFilter("pipeline_name", undefined);
@@ -155,7 +162,7 @@ export function PipelineRunFiltersBar({
155162
const separator = fromStr && toStr ? " – " : "";
156163

157164
allBadges.push({
158-
key: "date",
165+
key: "date_range",
159166
label: `${fromStr}${separator}${toStr}`,
160167
onRemove: () =>
161168
setFilters({ created_after: undefined, created_before: undefined }),

0 commit comments

Comments
 (0)