-
Notifications
You must be signed in to change notification settings - Fork 41
Expand file tree
/
Copy pathcoana-fix.mts
More file actions
717 lines (650 loc) · 20.9 KB
/
coana-fix.mts
File metadata and controls
717 lines (650 loc) · 20.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
import { promises as fs } from 'node:fs'
import os from 'node:os'
import path from 'node:path'
import { joinAnd } from '@socketsecurity/registry/lib/arrays'
import { debugDir, debugFn } from '@socketsecurity/registry/lib/debug'
import { readJsonSync } from '@socketsecurity/registry/lib/fs'
import { logger } from '@socketsecurity/registry/lib/logger'
import { pluralize } from '@socketsecurity/registry/lib/words'
import {
cleanupErrorBranches,
cleanupFailedPrBranches,
cleanupStaleBranch,
cleanupSuccessfulPrLocalBranch,
} from './branch-cleanup.mts'
import {
checkCiEnvVars,
getCiEnvInstructions,
getFixEnv,
} from './env-helpers.mts'
import { getSocketFixBranchName, getSocketFixCommitMessage } from './git.mts'
import { getSocketFixPrs, openSocketFixPr } from './pull-request.mts'
import {
DOT_SOCKET_DOT_FACTS_JSON,
FLAG_DRY_RUN,
GQL_PR_STATE_OPEN,
} from '../../constants.mts'
import { handleApiCall } from '../../utils/api.mts'
import { spawnCoanaDlx } from '../../utils/dlx.mts'
import { getErrorCause } from '../../utils/errors.mts'
import {
gitCheckoutBranch,
gitCommit,
gitCreateBranch,
gitDeleteBranch,
gitPushBranch,
gitRemoteBranchExists,
gitResetAndClean,
gitUnstagedModifiedFiles,
} from '../../utils/git.mts'
import {
enablePrAutoMerge,
fetchGhsaDetails,
setGitRemoteGithubRepoUrl,
} from '../../utils/github.mts'
import { getPackageFilesForScan } from '../../utils/path-resolve.mts'
import { setupSdk } from '../../utils/sdk.mts'
import { fetchSupportedScanFileNames } from '../scan/fetch-supported-scan-file-names.mts'
import type { FixConfig } from './types.mts'
import type { CResult } from '../../types.mts'
import type { PURL_Type } from '../../utils/ecosystem.mts'
import type { Spinner } from '@socketsecurity/registry/lib/spinner'
type DiscoverGhsaIdsOptions = {
coanaVersion?: string | undefined
cwd?: string | undefined
ecosystems?: PURL_Type[] | undefined
silence?: boolean | undefined
spinner?: Spinner | undefined
}
/**
* Discovers GHSA IDs by running coana without applying fixes.
* Returns a list of GHSA IDs, optionally limited.
*/
async function discoverGhsaIds(
orgSlug: string,
tarHash: string,
options?: DiscoverGhsaIdsOptions | undefined,
): Promise<string[]> {
const {
cwd = process.cwd(),
ecosystems,
silence = false,
spinner,
} = {
__proto__: null,
...options,
} as DiscoverGhsaIdsOptions
const foundCResult = await spawnCoanaDlx(
[
'find-vulnerabilities',
cwd,
'--manifests-tar-hash',
tarHash,
...(ecosystems?.length ? ['--purl-types', ...ecosystems] : []),
],
orgSlug,
{
cwd,
spinner: silence ? undefined : spinner,
coanaVersion: options?.coanaVersion,
},
{ stdio: 'pipe' },
)
if (foundCResult.ok) {
try {
// Coana prints ghsaIds as json-formatted string on the final line of the output.
const ghsaIdsRaw = foundCResult.data.trim().split('\n').pop()
if (ghsaIdsRaw) {
return JSON.parse(ghsaIdsRaw)
}
} catch {}
}
return []
}
export async function coanaFix(
fixConfig: FixConfig,
): Promise<CResult<{ fixedAll: boolean; ghsaDetails: unknown[] }>> {
const {
all,
applyFixes,
autopilot,
coanaVersion,
cwd,
debug,
disableMajorUpdates,
ecosystems,
exclude,
ghsas,
include,
minimumReleaseAge,
orgSlug,
outputFile,
prLimit,
showAffectedDirectDependencies,
silence,
spinner,
} = fixConfig
const fixEnv = await getFixEnv()
debugDir('inspect', { fixEnv })
if (!silence) {
spinner?.start()
}
const sockSdkCResult = await setupSdk()
if (!sockSdkCResult.ok) {
return sockSdkCResult
}
const sockSdk = sockSdkCResult.data
const supportedFilesCResult = await fetchSupportedScanFileNames({
spinner: silence ? undefined : spinner,
silence,
})
if (!supportedFilesCResult.ok) {
return supportedFilesCResult
}
const supportedFiles = supportedFilesCResult.data
const scanFilepaths = await getPackageFilesForScan(['.'], supportedFiles, {
cwd,
})
// Exclude any .socket.facts.json files that happen to be in the scan
// folder before the analysis was run.
const filepathsToUpload = scanFilepaths.filter(
p => path.basename(p).toLowerCase() !== DOT_SOCKET_DOT_FACTS_JSON,
)
const uploadCResult = await handleApiCall(
sockSdk.uploadManifestFiles(orgSlug, filepathsToUpload, cwd),
{
description: 'upload manifests',
spinner,
silence,
},
)
if (!uploadCResult.ok) {
return uploadCResult
}
const tarHash: string = (uploadCResult as any).data.tarHash
if (!tarHash) {
if (!silence) {
spinner?.stop()
}
return {
ok: false,
message:
'No tar hash returned from Socket API upload-manifest-files endpoint',
data: uploadCResult.data,
}
}
const shouldDiscoverGhsaIds = all || !ghsas.length
const shouldOpenPrs = fixEnv.isCi && fixEnv.repoInfo
if (!shouldOpenPrs) {
// In local mode, if neither --all nor --id is provided, show deprecation warning.
if (!silence && shouldDiscoverGhsaIds && !all) {
logger.warn(
'Implicit --all is deprecated in local mode and will be removed in a future release. Please use --all explicitly.',
)
}
// Inform user about local mode when fixes will be applied.
if (!silence && applyFixes && ghsas.length) {
const envCheck = checkCiEnvVars()
if (envCheck.present.length) {
// Some CI vars are set but not all - show what's missing.
if (envCheck.missing.length) {
logger.info(
'Running in local mode - fixes will be applied directly to your working directory.\n' +
`Missing environment variables for PR creation: ${joinAnd(envCheck.missing)}`,
)
}
} else {
// No CI vars are present - show general local mode message.
logger.info(
'Running in local mode - fixes will be applied directly to your working directory.\n' +
getCiEnvInstructions(),
)
}
}
// In local mode, process all discovered/provided IDs (no limit).
const ids: string[] = shouldDiscoverGhsaIds
? await discoverGhsaIds(orgSlug, tarHash, {
coanaVersion,
cwd,
ecosystems,
silence,
spinner,
})
: ghsas
if (ids.length === 0) {
if (!silence) {
spinner?.stop()
}
return { ok: true, data: { fixedAll: false, ghsaDetails: [] } }
}
// Create a temporary file for the output.
const tmpDir = os.tmpdir()
const tmpFile = path.join(tmpDir, `socket-fix-${Date.now()}.json`)
try {
const fixCResult = await spawnCoanaDlx(
[
'compute-fixes-and-upgrade-purls',
cwd,
'--manifests-tar-hash',
tarHash,
'--apply-fixes-to',
...ids,
...(fixConfig.rangeStyle
? ['--range-style', fixConfig.rangeStyle]
: []),
...(minimumReleaseAge
? ['--minimum-release-age', minimumReleaseAge]
: []),
...(include.length ? ['--include', ...include] : []),
...(exclude.length ? ['--exclude', ...exclude] : []),
...(ecosystems.length ? ['--purl-types', ...ecosystems] : []),
...(!applyFixes ? [FLAG_DRY_RUN] : []),
'--output-file',
tmpFile,
...(debug ? ['--debug'] : []),
...(disableMajorUpdates ? ['--disable-major-updates'] : []),
...(showAffectedDirectDependencies
? ['--show-affected-direct-dependencies']
: []),
...fixConfig.unknownFlags,
],
fixConfig.orgSlug,
{
coanaVersion,
cwd,
spinner: silence ? undefined : spinner,
stdio: silence ? 'pipe' : 'inherit',
},
)
if (!silence) {
spinner?.stop()
}
if (!fixCResult.ok) {
return fixCResult
}
// Read the temporary file to get the actual fixes result.
const fixesResultJson = readJsonSync(tmpFile, { throws: false }) as
| { fixes?: Record<string, unknown> }
| null
| undefined
// Copy to outputFile if provided.
if (outputFile) {
if (!silence) {
logger.info(`Copying fixes result to ${outputFile}`)
}
const tmpContent = await fs.readFile(tmpFile, 'utf8')
await fs.writeFile(outputFile, tmpContent, 'utf8')
}
return {
ok: true,
data: {
fixedAll: true,
ghsaDetails: fixesResultJson ? [fixesResultJson] : [],
},
}
} finally {
// Clean up the temporary file.
try {
await fs.unlink(tmpFile)
} catch {
// Ignore cleanup errors.
}
}
}
// Adjust PR limit based on open Socket Fix PRs.
let adjustedPrLimit = prLimit
if (shouldOpenPrs && fixEnv.repoInfo) {
try {
const openPrs = await getSocketFixPrs(
fixEnv.repoInfo.owner,
fixEnv.repoInfo.repo,
{ states: GQL_PR_STATE_OPEN },
)
const openPrCount = openPrs.length
// Reduce limit by number of open PRs to avoid creating too many.
adjustedPrLimit = Math.max(0, prLimit - openPrCount)
if (openPrCount > 0) {
debugFn(
'notice',
`prLimit: adjusted from ${prLimit} to ${adjustedPrLimit} (${openPrCount} open Socket Fix ${pluralize('PR', openPrCount)}`,
)
}
} catch (e) {
debugFn('warn', 'Failed to count open PRs, using original limit')
debugDir('error', e)
}
}
const shouldSpawnCoana = adjustedPrLimit > 0
let ids: string[] | undefined
if (shouldSpawnCoana) {
ids = (
shouldDiscoverGhsaIds
? await discoverGhsaIds(orgSlug, tarHash, {
coanaVersion,
cwd,
ecosystems,
silence,
spinner,
})
: ghsas
).slice(0, adjustedPrLimit)
}
if (!ids?.length) {
debugFn('notice', 'miss: no GHSA IDs to process')
}
if (!fixEnv.repoInfo) {
debugFn('notice', 'miss: no repo info detected')
}
if (!ids?.length || !fixEnv.repoInfo) {
if (!silence) {
spinner?.stop()
}
return { ok: true, data: { fixedAll: false, ghsaDetails: [] } }
}
debugFn('notice', `fetch: ${ids.length} GHSA details for ${joinAnd(ids)}`)
const ghsaDetails = await fetchGhsaDetails(ids)
const scanBaseNames = new Set(scanFilepaths.map(p => path.basename(p)))
debugFn('notice', `found: ${ghsaDetails.size} GHSA details`)
let count = 0
let overallFixed = false
const ghsaFixResults: unknown[] = []
// Process each GHSA ID individually.
ghsaLoop: for (let i = 0, { length } = ids; i < length; i += 1) {
const ghsaId = ids[i]!
debugFn('notice', `check: ${ghsaId}`)
// Create a temporary file for Coana output.
const tmpDir = os.tmpdir()
const tmpFile = path.join(tmpDir, `socket-fix-${ghsaId}-${Date.now()}.json`)
// Apply fix for single GHSA ID.
// eslint-disable-next-line no-await-in-loop
const fixCResult = await spawnCoanaDlx(
[
'compute-fixes-and-upgrade-purls',
cwd,
'--manifests-tar-hash',
tarHash,
'--apply-fixes-to',
ghsaId,
...(fixConfig.rangeStyle
? ['--range-style', fixConfig.rangeStyle]
: []),
...(minimumReleaseAge
? ['--minimum-release-age', minimumReleaseAge]
: []),
...(include.length ? ['--include', ...include] : []),
...(exclude.length ? ['--exclude', ...exclude] : []),
...(ecosystems.length ? ['--purl-types', ...ecosystems] : []),
...(debug ? ['--debug'] : []),
...(disableMajorUpdates ? ['--disable-major-updates'] : []),
...(showAffectedDirectDependencies
? ['--show-affected-direct-dependencies']
: []),
'--output-file',
tmpFile,
...fixConfig.unknownFlags,
],
fixConfig.orgSlug,
{
coanaVersion,
cwd,
spinner: silence ? undefined : spinner,
stdio: silence ? 'pipe' : 'inherit',
},
)
if (!fixCResult.ok) {
if (!silence) {
logger.error(
`Update failed for ${ghsaId}: ${getErrorCause(fixCResult)}`,
)
}
// Clean up temp file on failure.
try {
// eslint-disable-next-line no-await-in-loop
await fs.unlink(tmpFile)
} catch {
// Ignore cleanup errors.
}
continue ghsaLoop
}
// Check for modified files after applying the fix.
// eslint-disable-next-line no-await-in-loop
const unstagedCResult = await gitUnstagedModifiedFiles(cwd)
const modifiedFiles = unstagedCResult.ok
? unstagedCResult.data.filter(relPath =>
scanBaseNames.has(path.basename(relPath)),
)
: []
if (!modifiedFiles.length) {
debugFn('notice', `skip: no changes for ${ghsaId}`)
// Clean up temp file before continuing.
try {
// eslint-disable-next-line no-await-in-loop
await fs.unlink(tmpFile)
} catch {
// Ignore cleanup errors.
}
continue ghsaLoop
}
overallFixed = true
const branch = getSocketFixBranchName(ghsaId)
try {
// Check if an open PR already exists for this GHSA.
// eslint-disable-next-line no-await-in-loop
const existingOpenPrs = await getSocketFixPrs(
fixEnv.repoInfo.owner,
fixEnv.repoInfo.repo,
{ ghsaId, states: GQL_PR_STATE_OPEN },
)
if (existingOpenPrs.length > 0) {
const prNum = existingOpenPrs[0]!.number
if (!silence) {
logger.info(`PR #${prNum} already exists for ${ghsaId}, skipping.`)
}
debugFn('notice', `skip: open PR #${prNum} exists for ${ghsaId}`)
continue ghsaLoop
}
// If branch exists but no open PR, delete the stale branch.
// This handles cases where PR creation failed but branch was pushed.
// eslint-disable-next-line no-await-in-loop
if (await gitRemoteBranchExists(branch, cwd)) {
// eslint-disable-next-line no-await-in-loop
const shouldContinue = await cleanupStaleBranch(branch, ghsaId, cwd)
if (!shouldContinue) {
continue ghsaLoop
}
}
// Check for GitHub token before doing any git operations.
if (!fixEnv.githubToken) {
if (!silence) {
logger.error(
'Cannot create pull request: SOCKET_CLI_GITHUB_TOKEN environment variable is not set.\n' +
'Set SOCKET_CLI_GITHUB_TOKEN or GITHUB_TOKEN to enable PR creation.',
)
}
debugFn('error', `skip: missing GitHub token for ${ghsaId}`)
continue ghsaLoop
}
debugFn('notice', `pr: creating for ${ghsaId}`)
const details = ghsaDetails.get(ghsaId)
debugFn(
'notice',
`ghsa: ${ghsaId} details ${details ? 'found' : 'missing'}`,
)
const pushed =
// eslint-disable-next-line no-await-in-loop
(await gitCreateBranch(branch, cwd)) &&
// eslint-disable-next-line no-await-in-loop
(await gitCheckoutBranch(branch, cwd)) &&
// eslint-disable-next-line no-await-in-loop
(await gitCommit(
getSocketFixCommitMessage(ghsaId, details),
modifiedFiles,
{
cwd,
email: fixEnv.gitEmail,
user: fixEnv.gitUser,
},
)) &&
// eslint-disable-next-line no-await-in-loop
(await gitPushBranch(branch, cwd))
if (!pushed) {
if (!silence) {
logger.warn(`Push failed for ${ghsaId}, skipping PR creation.`)
}
// eslint-disable-next-line no-await-in-loop
await gitResetAndClean(fixEnv.baseBranch, cwd)
// eslint-disable-next-line no-await-in-loop
await gitCheckoutBranch(fixEnv.baseBranch, cwd)
// eslint-disable-next-line no-await-in-loop
await gitDeleteBranch(branch, cwd)
continue ghsaLoop
}
// Set up git remote.
// eslint-disable-next-line no-await-in-loop
await setGitRemoteGithubRepoUrl(
fixEnv.repoInfo.owner,
fixEnv.repoInfo.repo,
fixEnv.githubToken,
cwd,
)
// eslint-disable-next-line no-await-in-loop
const prResult = await openSocketFixPr(
fixEnv.repoInfo.owner,
fixEnv.repoInfo.repo,
branch,
// Single GHSA ID.
[ghsaId],
{
baseBranch: fixEnv.baseBranch,
cwd,
ghsaDetails,
},
)
if (prResult.ok) {
const { data } = prResult.pr
const prRef = `PR #${data.number}`
// Read the fix result JSON and merge with PR data.
const fixResultJson = readJsonSync(tmpFile, { throws: false })
if (fixResultJson && typeof fixResultJson === 'object') {
ghsaFixResults.push({
...(fixResultJson as object),
pullRequestLink: data.html_url,
pullRequestNumber: data.number,
})
}
if (!silence) {
logger.success(`Opened ${prRef} for ${ghsaId}.`)
}
if (autopilot) {
if (!silence) {
logger.indent()
spinner?.indent()
}
// eslint-disable-next-line no-await-in-loop
const { details, enabled } = await enablePrAutoMerge(data)
if (!silence) {
if (enabled) {
logger.info(`Auto-merge enabled for ${prRef}.`)
} else {
const message = `Failed to enable auto-merge for ${prRef}${
details ? `:\n${details.map(d => ` - ${d}`).join('\n')}` : '.'
}`
logger.error(message)
}
logger.dedent()
spinner?.dedent()
}
}
// Clean up local branch only - keep remote branch for PR merge.
// eslint-disable-next-line no-await-in-loop
await cleanupSuccessfulPrLocalBranch(branch, cwd)
} else {
// Handle PR creation failures.
if (prResult.reason === 'already_exists') {
if (!silence) {
logger.info(
`PR already exists for ${ghsaId} (this should not happen due to earlier check).`,
)
}
// Don't delete branch - PR exists and needs it.
} else if (prResult.reason === 'validation_error') {
if (!silence) {
logger.error(
`Failed to create PR for ${ghsaId}:\n${prResult.details}`,
)
}
// eslint-disable-next-line no-await-in-loop
await cleanupFailedPrBranches(branch, cwd)
} else if (prResult.reason === 'permission_denied') {
if (!silence) {
logger.error(
`Failed to create PR for ${ghsaId}: Permission denied. Check SOCKET_CLI_GITHUB_TOKEN permissions.`,
)
}
// eslint-disable-next-line no-await-in-loop
await cleanupFailedPrBranches(branch, cwd)
} else if (prResult.reason === 'network_error') {
if (!silence) {
logger.error(
`Failed to create PR for ${ghsaId}: Network error. Please try again.`,
)
}
// eslint-disable-next-line no-await-in-loop
await cleanupFailedPrBranches(branch, cwd)
} else {
if (!silence) {
logger.error(
`Failed to create PR for ${ghsaId}: ${prResult.error.message}`,
)
}
// eslint-disable-next-line no-await-in-loop
await cleanupFailedPrBranches(branch, cwd)
}
}
// Reset back to base branch for next iteration.
// eslint-disable-next-line no-await-in-loop
await gitResetAndClean(fixEnv.baseBranch, cwd)
// eslint-disable-next-line no-await-in-loop
await gitCheckoutBranch(fixEnv.baseBranch, cwd)
} catch (e) {
if (!silence) {
logger.warn(
`Unexpected condition: Push failed for ${ghsaId}, skipping PR creation.`,
)
}
debugDir('error', e)
// Clean up branches (push may have succeeded before error).
// eslint-disable-next-line no-await-in-loop
const remoteBranchExists = await gitRemoteBranchExists(branch, cwd)
// eslint-disable-next-line no-await-in-loop
await cleanupErrorBranches(branch, cwd, remoteBranchExists)
// eslint-disable-next-line no-await-in-loop
await gitResetAndClean(fixEnv.baseBranch, cwd)
// eslint-disable-next-line no-await-in-loop
await gitCheckoutBranch(fixEnv.baseBranch, cwd)
} finally {
// Clean up temp file.
try {
// eslint-disable-next-line no-await-in-loop
await fs.unlink(tmpFile)
} catch {
// Ignore cleanup errors.
}
}
count += 1
debugFn(
'notice',
`increment: count ${count}/${Math.min(adjustedPrLimit, ids.length)}`,
)
if (count >= adjustedPrLimit) {
break ghsaLoop
}
}
if (!silence) {
spinner?.stop()
}
return {
ok: true,
data: { fixedAll: overallFixed, ghsaDetails: ghsaFixResults },
}
}