Hidden Grottos Missing in API

[notblisy]

This encounter type is exclusive to B2W2:

• https://bulbapedia.bulbagarden.net/wiki/Hidden_Grotto#Locations

I think this is fairly simple to include. We add a new encounter type called "hidden grotto"

After that, it's a matter of adding encounters to each location_area and encounter slots.

I don't think much else needs to be added for them.

I'll look into this in the coming weeks if no one else does as I chip away at missing encounter data in gens 1-7.

[notblisy]

As mentioned in #1446 I wanted to briefly lay out how I think hidden grottos should be modeled for their locations and location areas.

For mirage islands and pokespots in XD, we have set a "mirage island" location, and then make each mirage island itself a location area of that mirage spot.

However, for Hidden grottos, I believe it's better suited for each of them to be a location_area of whichever route or location they're in. They're basically little cave entrances on each route. bulbapedia article

I think it makes the most sense to check for a route and see what areas could be subareas of said route, and see that there's a hidden grotto sub area. Thoughts?

I'll tag @jemarq04 since we were discussing this previously in 1446.

[jemarq04]

It definitely looks like it'll be much better to implement how you're suggesting for the grottoes - I just reminded myself of how/where they appear and it's definitely better with new location areas for pre-existing locations in the API

[notblisy]

Sounds great! Obviously I've got a lot of other old gen locations to fix up, but I'll tackle this when I get to it if no one else does.