Skip to content

Compatibility with CK3 1.18 #3698

Compatibility with CK3 1.18

Compatibility with CK3 1.18 #3698

Triggered via pull request January 11, 2026 11:12
Status Success
Total duration 2m 18s
Artifacts

build.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
build (macos-14): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L892
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (macos-14): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L838
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (macos-14): ImperatorToCK3/CK3/Localization/CK3LocBlock.cs#L8
TODO add ILocBlock interface that both this and commonItems' LocBlock would implement. (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (macos-14): ImperatorToCK3/CK3/CK3LocDB.cs#L103
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (macos-14): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L1135
Argument of type 'Dictionary<string, Title?>' cannot be used for parameter 'heritageToEmpireDict' of type 'Dictionary<string, Title>' in 'void LandedTitles.SplitDisconnectedEmpires(FrozenDictionary<string, ConcurrentHashSet<string>> kingdomAdjacenciesByLand, FrozenDictionary<string, ConcurrentHashSet<string>> kingdomAdjacenciesByWaterBody, HashSet<string> removableEmpireIds, Dictionary<string, ImmutableArray<Pillar>> kingdomToDominantHeritagesDict, Dictionary<string, Title> heritageToEmpireDict, CK3LocDB ck3LocDB, Date date)' due to differences in the nullability of reference types.
build (macos-14): ImperatorToCK3/Imperator/World.cs#L298
Non-nullable field 'diplomacyDB' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
build (self-hosted, linux): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L892
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (self-hosted, linux): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L838
TODO when the holding owner of the primary I:R province is not able to hold the CK3 equivalent, also check the holding owners from secondary source provinces (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (self-hosted, linux): ImperatorToCK3/CK3/Localization/CK3LocBlock.cs#L8
TODO add ILocBlock interface that both this and commonItems' LocBlock would implement. (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (self-hosted, linux): ImperatorToCK3/CK3/CK3LocDB.cs#L103
TODO add unit test for combining loc from all the sources into one locblock (https://github.com/meziantou/Meziantou.Analyzer/blob/main/docs/Rules/MA0026.md)
build (self-hosted, linux): ImperatorToCK3/CK3/Titles/LandedTitles.cs#L1135
Argument of type 'Dictionary<string, Title?>' cannot be used for parameter 'heritageToEmpireDict' of type 'Dictionary<string, Title>' in 'void LandedTitles.SplitDisconnectedEmpires(FrozenDictionary<string, ConcurrentHashSet<string>> kingdomAdjacenciesByLand, FrozenDictionary<string, ConcurrentHashSet<string>> kingdomAdjacenciesByWaterBody, HashSet<string> removableEmpireIds, Dictionary<string, ImmutableArray<Pillar>> kingdomToDominantHeritagesDict, Dictionary<string, Title> heritageToEmpireDict, CK3LocDB ck3LocDB, Date date)' due to differences in the nullability of reference types.
build (self-hosted, linux): ImperatorToCK3/Imperator/World.cs#L298
Non-nullable field 'diplomacyDB' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.