fix: windows support

Author: triniwiz

lib/common/file-system.ts

@@ -135,12 +135,18 @@ export class FileSystem implements IFileSystem {
 	}
 
 	public deleteDirectory(directory: string): void {
-		shelljs.rm("-rf", directory);
-
-		const err = shelljs.error();
-
-		if (err !== null) {
-			throw new Error(err);
+		// fs.rmSync handles Windows edge cases (read-only attributes, long paths)
+		// more reliably than shelljs.rm on Node.js 20+.
+		try {
+			fs.rmSync(directory, { recursive: true, force: true });
+		} catch (e: any) {
+			// If rmSync itself fails (e.g., files locked by another process on Windows),
+			// fall back to shelljs so behaviour on other platforms is unchanged.
+			shelljs.rm("-rf", directory);
+			const err = shelljs.error();
+			if (err !== null) {
+				throw new Error(e?.message ?? err);
+			}
 		}
 	}
 

lib/common/mobile/windows/windows-application-manager.ts

@@ -1,4 +1,5 @@
 import * as fs from "fs";
+import * as os from "os";
 import * as path from "path";
 import { spawn } from "child_process";
 import { ApplicationManagerBase } from "../application-manager-base";
@@ -81,6 +82,19 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 		}
 
 		this.$logger.info(`[Windows] Installing MSIX/APPX from: ${packageFilePath}`);
+		// If we have an app identifier, try to remove any existing package first to
+		// avoid the "package is already installed" HRESULT (0x80073CFB) which
+		// blocks re-registration in development flows.
+		if (appIdentifier) {
+			try {
+				this.$logger.info(`[Windows] Attempting to remove existing package: ${appIdentifier}`);
+				// uninstallApplication handles EXE cleanup and runs the Remove-AppxPackage
+				// command for UWP packages. Ignore errors and proceed to install.
+				await this.uninstallApplication(appIdentifier);
+			} catch (err) {
+				this.$logger.warn(`[Windows] Pre-install uninstall failed: ${err}`);
+			}
+		}
 		await this.$childProcess.spawnFromEvent(
 			"powershell.exe",
 			[
@@ -128,9 +142,33 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 		await this.startApplication(appData);
 	}
 
+	/**
+	 * Returns the path of the runtime's trace log for the most recently started app.
+	 * For UWP-packaged apps the runtime DLL writes inside the app container's TempState,
+	 * not the global system temp directory. Falls back to the system temp path used when
+	 * the app is launched as an unpackaged EXE.
+	 */
+	public getLogFilePath(): string {
+		const systemTempLog = path.join(os.tmpdir(), "ns_trace.log");
+		if (this._packageFamilyNames.size > 0) {
+			const pfn = this._packageFamilyNames.values().next().value as string;
+			const localAppData = process.env.LOCALAPPDATA;
+			if (localAppData && pfn) {
+				return path.join(localAppData, "Packages", pfn, "TempState", "ns_trace.log");
+			}
+		}
+		return systemTempLog;
+	}
+
 	public async startApplication(
 		appData: Mobile.IStartApplicationData,
 	): Promise<void> {
+		// Truncate the trace log so the streamer starts from a clean state each run.
+		try {
+			const logPath = this.getLogFilePath();
+			fs.writeFileSync(logPath, "", "utf8");
+		} catch { /* ignore — log dir may not exist yet */ }
+
 		const exeCandidate =
 			(appData.appId && this._installedExePaths[appData.appId]) ||
 			(appData.projectName && this._installedExePaths[appData.projectName]);
@@ -159,8 +197,11 @@ export class WindowsApplicationManager extends ApplicationManagerBase {
 		if (appData.waitForDebugger) {
 			this._writeDebugBreakMarker(pfn);
 		}
-		this.$logger.info(`[Windows] Launching UWP: ${pfn}`);
-		const proc = spawn("explorer.exe", [`ms-windows-app://${pfn}`], {
+		// UWP apps are launched via shell:AppsFolder\<PFN>!<ApplicationId>.
+		// The ApplicationId comes from the <Application Id="..."> attribute in the manifest.
+		const appId = "App";
+		this.$logger.info(`[Windows] Launching UWP: ${pfn}!${appId}`);
+		const proc = spawn("explorer.exe", [`shell:AppsFolder\\${pfn}!${appId}`], {
 			detached: true,
 			stdio: "ignore",
 		});

lib/common/mobile/windows/windows-device-file-system.ts

@@ -48,11 +48,7 @@ export class WindowsDeviceFileSystem implements Mobile.IDeviceFileSystem {
 		_deviceAppData: Mobile.IDeviceAppData,
 		localToDevicePaths: Mobile.ILocalToDevicePathData[],
 	): Promise<Mobile.ILocalToDevicePathData[]> {
-		for (const item of localToDevicePaths) {
-			const dest = item.getDevicePath();
-			fs.mkdirSync(path.dirname(dest), { recursive: true });
-			fs.copyFileSync(item.getLocalPath(), dest);
-		}
+		this._syncPaths(localToDevicePaths);
 		return localToDevicePaths;
 	}
 
@@ -61,7 +57,29 @@ export class WindowsDeviceFileSystem implements Mobile.IDeviceFileSystem {
 		localToDevicePaths: Mobile.ILocalToDevicePathData[],
 		_projectFilesPath: string,
 	): Promise<Mobile.ILocalToDevicePathData[]> {
-		return this.transferFiles(_deviceAppData, localToDevicePaths);
+		this._syncPaths(localToDevicePaths);
+		return localToDevicePaths;
+	}
+
+	private _syncPaths(localToDevicePaths: Mobile.ILocalToDevicePathData[]): void {
+		for (const pathData of localToDevicePaths) {
+			const src = pathData.getLocalPath();
+			const dest = pathData.getDevicePath();
+			if (src === dest) {
+				continue;
+			}
+			try {
+				const stat = fs.statSync(src);
+				if (stat.isDirectory()) {
+					fs.mkdirSync(dest, { recursive: true });
+				} else {
+					fs.mkdirSync(path.dirname(dest), { recursive: true });
+					fs.copyFileSync(src, dest);
+				}
+			} catch {
+				// skip entries that disappeared between detection and sync
+			}
+		}
 	}
 
 	public async transferFile(

lib/common/mobile/windows/windows-device.ts

@@ -1,4 +1,5 @@
 import * as os from "os";
+import * as fs from "fs";
 import { DeviceConnectionType } from "../../../constants";
 import { CONNECTED_STATUS, DeviceTypes } from "../../constants";
 import { WindowsApplicationManager } from "./windows-application-manager";
@@ -25,10 +26,12 @@ export class WindowsDevice implements Mobile.IDevice {
 		connectionTypes: [DeviceConnectionType.Local],
 	};
 
+	private _logTailInterval: ReturnType<typeof setInterval> | null = null;
+
 	constructor(
 		$logger: ILogger,
 		$hooksService: IHooksService,
-		$deviceLogProvider: Mobile.IDeviceLogProvider,
+		private $deviceLogProvider: Mobile.IDeviceLogProvider,
 		$childProcess: IChildProcess,
 	) {
 		this.applicationManager = new WindowsApplicationManager(
@@ -41,7 +44,48 @@ export class WindowsDevice implements Mobile.IDevice {
 	}
 
 	public async openDeviceLogStream(): Promise<void> {
-		// Windows runtime logs go to stdout/stderr of the process
-		// DevTools console output is available on ws://localhost:9229
+		if (this._logTailInterval) {
+			clearInterval(this._logTailInterval);
+			this._logTailInterval = null;
+		}
+
+		// For packaged UWP apps, GetTempPath() inside the app container resolves to
+		// %LOCALAPPDATA%\Packages\<PFN>\TempState — not the system temp dir.
+		// Ask the application manager for the correct path based on the known PFN.
+		const manager = this.applicationManager as WindowsApplicationManager;
+		const logPath = manager.getLogFilePath();
+		const deviceId = this.deviceInfo.identifier;
+
+		// Start from the current end of the file so stale output is not replayed.
+		let offset = 0;
+		try { offset = fs.statSync(logPath).size; } catch { /* file not yet created */ }
+
+		// Rotate the log if it exceeds 10 MB to prevent unbounded disk growth.
+		const MAX_LOG_BYTES = 10 * 1024 * 1024;
+
+		this._logTailInterval = setInterval(() => {
+			try {
+				const stat = fs.statSync(logPath);
+				if (stat.size <= offset) return;
+
+				const toRead = stat.size - offset;
+				const buf = Buffer.alloc(toRead);
+				const fd = fs.openSync(logPath, "r");
+				fs.readSync(fd, buf, 0, toRead, offset);
+				fs.closeSync(fd);
+				offset = stat.size;
+
+				const lines = buf.toString("utf8").split(/\r?\n/);
+				for (const line of lines) {
+					if (line.trim()) {
+						this.$deviceLogProvider.logData(line, "Windows", deviceId);
+					}
+				}
+
+				if (stat.size > MAX_LOG_BYTES) {
+					try { fs.writeFileSync(logPath, "", "utf8"); offset = 0; } catch { /* ignore */ }
+				}
+			} catch { /* ignore — file may not exist between app restarts */ }
+		}, 250);
 	}
 }

lib/controllers/prepare-controller.ts

@@ -15,6 +15,7 @@ import {
 	AnalyticsEventLabelDelimiter,
 	BUNDLER_COMPILATION_COMPLETE,
 	CONFIG_FILE_NAME_JS,
+	APP_FOLDER_NAME,
 	CONFIG_FILE_NAME_TS,
 	PACKAGE_JSON_FILE_NAME,
 	PLATFORMS_DIR_NAME,
@@ -485,11 +486,9 @@ export class PrepareController extends EventEmitter {
 		} else if (
 			this.$mobileHelper.isWindowsPlatform(platformData.platformNameLowerCase)
 		) {
-			// Windows apps place the packaged app under <projectRoot>/<projectName>/App
 			packagePath = path.join(
-				platformData.projectRoot,
-				projectData.projectName,
-				"app",
+				platformData.appDestinationDirectoryPath,
+				APP_FOLDER_NAME,
 				"package.json",
 			);
 		} else {

lib/definitions/livesync.d.ts

@@ -508,6 +508,7 @@ declare global {
 		appIdentifier: string;
 		getDirname?: boolean;
 		watch?: boolean;
+		projectData?: IProjectData;
 	}
 
 	interface IDevicePathProvider {

lib/definitions/project.d.ts

@@ -134,6 +134,8 @@ interface INsConfigIOS extends INsConfigPlaform {
 
 interface INSConfigVisionOS extends INsConfigIOS {}
 
+interface INsConfigWindows extends INsConfigPlaform {}
+
 interface INsConfigAndroid extends INsConfigPlaform {
 	v8Flags?: string;
 
@@ -188,6 +190,7 @@ interface INsConfig {
 	ios?: INsConfigIOS;
 	android?: INsConfigAndroid;
 	visionos?: INSConfigVisionOS;
+	windows?: INsConfigWindows;
 	ignoredNativeDependencies?: string[];
 	hooks?: INsConfigHooks[];
 	projectName?: string;

lib/device-path-provider.ts

@@ -52,13 +52,18 @@ export class DevicePathProvider implements IDevicePathProvider {
 		} else if (
 			this.$mobileHelper.isWindowsPlatform(device.deviceInfo.platform)
 		) {
-			const projectData = (options as any).projectData;
+			const projectData = options.projectData;
 			if (projectData) {
 				const platformData = this.$platformsDataService.getPlatformData(
 					device.deviceInfo.platform,
 					projectData,
 				);
-				return platformData.appDestinationDirectoryPath;
+				// Sync into bin\app — the registered package root — so the running app
+				// picks up changes without a rebuild.
+				return path.join(
+					platformData.getBuildOutputPath({} as never),
+					APP_FOLDER_NAME,
+				);
 			}
 		}
 

lib/project-data.ts

@@ -326,13 +326,15 @@ export class ProjectData implements IProjectData {
 				ios: "",
 				android: "",
 				visionos: "",
+				windows: "",
 			};
 		}
 
 		const identifier: Mobile.IProjectIdentifier = {
 			ios: config.id,
 			android: config.id,
 			visionos: config.id,
+			windows: config.id,
 		};
 
 		if (config.ios && config.ios.id) {
@@ -344,6 +346,9 @@ export class ProjectData implements IProjectData {
 		if (config.visionos && config.visionos.id) {
 			identifier.visionos = config.visionos.id;
 		}
+		if (config.windows && config.windows.id) {
+			identifier.windows = config.windows.id;
+		}
 
 		return identifier;
 	}

lib/services/build-data-service.ts

@@ -1,4 +1,4 @@
-import { AndroidBuildData, IOSBuildData } from "../data/build-data";
+import { AndroidBuildData, BuildData, IOSBuildData } from "../data/build-data";
 import { IBuildDataService } from "../definitions/build";
 import { injector } from "../common/yok";
 
@@ -10,6 +10,8 @@ export class BuildDataService implements IBuildDataService {
 			return new IOSBuildData(projectDir, platform, data);
 		} else if (this.$mobileHelper.isAndroidPlatform(platform)) {
 			return new AndroidBuildData(projectDir, platform, data);
+		} else if (this.$mobileHelper.isWindowsPlatform(platform)) {
+			return new BuildData(projectDir, platform, data);
 		}
 	}
 }