Merge pull request #131 from MoonModules/effects-palettes

Palettes and effects

Author: ewowi

misc/parking/.gemini/settings.json misc/instructions/.gemini/settings.jsonmisc/parking/.gemini/settings.json renamed to misc/instructions/.gemini/settings.json

@@ -0,0 +1,33 @@
+- Moonlight is a fork of Upstream sveltekit repo (theelims/ESP32-sveltekit): 
+    - /interface except moonbase folders (frontend)
+    - /lib folder (backend)
+    - Changes in upstream code has been commented with // 🌙 (moonbase) or // 💫 (moonlight)
+    - Core benefits of upstream sveltekit: state and services with subscriptions and up and running svelte (reactive framework)
+    - Improvements to the sveltekit stuff can be added, but always submitting a pull request to upstream needs to be considered. In theory all the  // 🌙 are possible PR’s but for different reasons they not always end up in upstream
+    - MoonLight UI is now pretty much inspired by the UI used in upstream. Future goals is to develop more 
+- Repo is split in 
+    - moonbase (everything not lights related, see for instance env:esp32-d0-moonbase in esp32-d0.ini, compiles only moonbase, not moonlight. Can be the basis for any IOT project)
+    - Moonlight: everything lights related
+- MoonBase / MoonLight
+    - /src contains everything moonbase and moonlight specific
+    - See /src/MoonBase: some files contains MoonLight specifics, e.g. Nodes.h/.cpp. This is work in progress, eventually things like Nodes should be generic also for non light applications.
+    - pal.h and pal_espidf.cpp as a first attempt to come to an esp-idf only repository (not using arduino). This is very much work in progress.
+    - Modules and nodes are the core concepts of MoonBase/MoonLight. Modules are fully generated frontend(UI)/backend(server) modules (no specific sveltekit code per module, see /interface/src/lib/components/moonbase and  /interface/src/routes/moonbase for Module specific code)
+    - Monitor module is now also lights specific, in the future should be a generic moonbase feature.
+    - Lightscontrol is now also lights specific, in the future should be a generic module, maybe renamed to something more generic. Lightscontrol is the interface / API to the outside world. e.g. DMX, IR, Home assistant etc, all have the variables / rest api / web sockets / … of lights control as their interface point
+    - MoonLight core concepts are physical and virtual layer. The physical layer has a double buffered / two array called channelsE/D: channels for effects and channels for drivers. Main.cpp manages the double buffering / producer/consumer synchronization of the two arrays in a way 2 core MCU’s like the ESP32 series uses one core for the producer (effects) and 1 core for the consumer (drivers)
+    - The channel array(s) are a generalization of FastLED’s CRGB leds. In FastLED’s, each entry is one CRGB object. In Moonlight each entry is one light with a nrOfChannels. So RGB lights have 3 nrOfChannels, RGBW 4, but other lights like moving heads are also supported (can be up to 24/32/… lights) 
+    - The effects module contains effect nodes and modifier nodes, the Driver module contains layout and driver nodes.
+    - Eventually the effects and drivers module will be replaced / augmented by a graphical interface showing nodes, connected to other nodes in different lanes (e.g. physical lane and multiple virtual layer lanes)
+    - MoonLight currently supports audio reactivity by using https://github.com/netmindz/WLED-sync, depending on a WLED-MM device transmitting audio over the network. Implementing FastLED audio is work in progress, WLED-MM audio is currently moved to a separate library and in the future will also be added as an audio node. These 2 options allow for Audio processing indepenent of another device running WLED.
+    - MoonLight documentation is maintained in the same repo and is deployed here: https://moonmodules.org/MoonLight/
+    - See architecture : https://moonmodules.org/MoonLight/develop/architecture/ for more details on system tasks, producer/consumer double bufering etc.
+    - /src/MoonLight/Nodes contain subfolders for all currently supported Effects, Modifiers, Driver and layout nodes. Each node is a class with constructor and destructor to manage all their memory usage (after deleting a node in the effects or drivers module, they should be completely reverse their resource claims). Nodes have controls, each node can define their own unique controls and is shown and managed in the UI.
+    - MoonLight supports different LED drivers , the FastLED channels api drivers and also physical led driver which is based on I2SClocklessDriver repo for non P4 and on parlio.h/cpp for P4. They can be used as alternatives.
+    - All pins are manager by the IO module by board presets. Board presets is the only place where pins are defined. Nodes can use the pin definitions (and can report back to the IO module). Currently the IO module supports also I2C, in the future I2S, SPi, … will also be supported.
+    - Live scripts (https://github.com/hpwit/ESPLiveScript.git) is supported, now MoonLight specific but should be moonbase functionality eventually. It allows for live coding of nodes. Currently effect and layout nodes are implemented but not tested for a while (due to some crashes and planned further development of that repo).
+- General
+    - MoonLight should run on all ESP32 devices. Mainly used and tested now on ESP32-D0 (standard dev MCU’s), ESP32-S3 and ESP32-P4. Running MoonLight on ESP32-D0 is a challenge as heap is pretty much used up, and Flash size is limited. We currently use a 3MB flash partition so 4MB boards cannot do OTA at the moment. In the future we plan to implement a minimal OTA partition (as investigated at Tasmota/ESPHome …), so also small flash size boards (4MB) can do OTA.
+    - Optimize on the critical process: running effects / modifiers (producers) and displaying them on leds (direct via pins on the board using led drivers or via Art-Net over the network). So code for the critical process should compile to minimal assembler code and checks on code should be minimal. (Example use int instead of unsigned int as no need to control if it is negative if the developer should ensure it is possible, or do not check if a const char * is null as it’s the developer responsibility to make sure this is the case). In short: the code should not be resilient to developer mistakes, the developer must solve the mistakes.
+    - Non critical processes can run in reasonable time, in general 20ms response time for UI is more than enough.
+    - See also GIMINI.md in /misc/parking for info about upstream sveltekit

misc/parking/GEMINI.md misc/instructions/GEMINI.mdmisc/parking/GEMINI.md renamed to misc/instructions/GEMINI.md

@@ -57,7 +57,7 @@ build_flags =
     -D BUILD_TARGET=\"$PIOENV\"
     -D APP_NAME=\"MoonLight\" ; 🌙 Must only contain characters from [a-zA-Z0-9-_] as this is converted into a filename
     -D APP_VERSION=\"0.8.1\" ; semver compatible version string
-    -D APP_DATE=\"20260224\" ; 🌙
+    -D APP_DATE=\"20260301\" ; 🌙
 
     -D PLATFORM_VERSION=\"pioarduino-55.03.37\" ; 🌙 make sure it matches with above plaftform
 
@@ -204,9 +204,20 @@ build_flags =
   -D DRIVERS_STACK_SIZE=6144 ;  psramFound() ? 4 * 1024 : 3 * 1024, 4096 is sufficient for now. Update: due to FastLED audio I had to increase to 6144 (might want to move audio to a separate task)
 
   ; -D FASTLED_TESTING ; causes duplicate definition of initSpiHardware(); - workaround: removed implementation in spi_hw_manager_esp32.cpp.hpp
-    -D FASTLED_BUILD=\"20260224\"
+    -D FASTLED_BUILD=\"20260226\"
 lib_deps =
-  https://github.com/FastLED/FastLED#56d49b14796fa14e4fcc3f394256ae0bbe509b65 ; master 20260224
+  https://github.com/FastLED/FastLED#809744a9738f7e390f345d597ea59700648de906 ; 
+  ; https://github.com/FastLED/FastLED#7e133f8f39480cac7ca5876fc78c980f874b527d ; 20260225 10:03 AM bass/mid/high looks nervous / all or nothing, doens't align with audio sweep (https://www.youtube.com/watch?v=PAsMlDptjx8)
+  ; https://github.com/FastLED/FastLED#5d7ce6f1fcd1cf3cccdc641636c66dd46ade44fc ; 20260224 9:16 PM FastLED driver websocket issue
+  ; https://github.com/FastLED/FastLED#8adee9130ea1849da6f9d01578171016e69f18c1 ; 20260224 8:35 PM FastLED driver websocket issue
+  ; https://github.com/FastLED/FastLED#56d49b14796fa14e4fcc3f394256ae0bbe509b65 ; master 20260224 8:49 AM (fix fl_* functions) ; FastLED driver websocket issue
+  ; https://github.com/FastLED/FastLED#6017ce6b94552fd57f5c0be60592902d8111b470 ; 20260224 5:15 fix  c6... not working ❌
+  ; https://github.com/FastLED/FastLED#629a1e468fd823a6834c1bd6430fedea522089ed ; 20260224 4:17 fix spam ... compile error 
+  ; https://github.com/FastLED/FastLED#8c0015af87908cb641907df69061321f6a306f0e ; 20260224 4:15 Channel engine ... compile error
+  ; https://github.com/FastLED/FastLED#4cef007214bdf70039576ccf60c9384981c06a0d ; 20260224 4:13 isqrt32 ... working ✅
+  ; https://github.com/FastLED/FastLED#595150340cb0034b50328bee8eaaaceaeb570dc7 ; 20260224 2:48 AM add filtering to audio detectors working
+  ; https://github.com/FastLED/FastLED#d03ffd69c68f1a00f883243f78b2a0e9bfb66298 ; master 2026023 6:15AM (fix no preamble for the UCS led chipset) websocket working!
+
   https://github.com/ewowi/WLED-sync#25f280b5e8e47e49a95282d0b78a5ce5301af4fe ; sourceIP + fftUdp.clear() if arduino >=3 (20251104)
 
 ; 💫 currently only enabled on s3 as esp32dev runs over 100%

misc/instructions/MoonLight.md

@@ -675,36 +675,47 @@ class ModuleIO : public Module {
   // on update triggers another onUpdates on 2 occasions: 1) newState modded (directly) and 2) setBoardPresetDefaults (via main loop)
   // each will trigger the updateHandler of this module sending readpins again ...
   void onUpdate(const UpdatedItem& updatedItem, const String& originId) override {
+    // Below updates only triggered from UI (not from backend updates)
+    if (!originId.toInt()) return;
+
     JsonDocument doc;
     JsonObject newState = doc.to<JsonObject>();
+
+    // Handle boardPreset changes
     if (updatedItem.name == "boardPreset") {
-      // if booting and modded is false or ! booting
-      if ((updatedItem.oldValue == "" && _state.data["modded"] == false) || updatedItem.oldValue != "") {  // only update unmodded
+      // Only load board defaults if modded is false
+      if (_state.data["modded"] == false) {
         EXT_LOGD(MB_TAG, "newBoardID %s %s[%d]%s[%d].%s = %s -> %s", originId.c_str(), updatedItem.parent[0].c_str(), updatedItem.index[0], updatedItem.parent[1].c_str(), updatedItem.index[1], updatedItem.name.c_str(), updatedItem.oldValue.c_str(), updatedItem.value.as<String>().c_str());
-        newBoardID = updatedItem.value;  // run in sveltekit task
+        newBoardID = updatedItem.value;  // Will be processed in loop20ms
+      } else {
+        EXT_LOGD(MB_TAG, "boardPreset change ignored - modded=true");
       }
+      return;  // Don't process further for boardPreset changes
     }
 
-    if (!originId.toInt()) return;  // below updates only triggered from UI
-
     if (updatedItem.name == "modded") {
-      // set pins to default if modded is turned off
+      // When modded is set to false, reload the current board preset defaults
       if (updatedItem.value == false) {
-        // EXT_LOGD(MB_TAG, "%s[%d]%s[%d].%s = %s -> %s", updatedItem.parent[0].c_str(), updatedItem.index[0], updatedItem.parent[1].c_str(), updatedItem.index[1], updatedItem.name.c_str(), updatedItem.oldValue.c_str(), updatedItem.value.as<String>().c_str());
-        newBoardID = _state.data["boardPreset"];  // run in sveltekit task
+        EXT_LOGD(MB_TAG, "modded set to false - reloading board defaults");
+        newBoardID = _state.data["boardPreset"];  // Reload current board
       }
     } else if (updatedItem.name == "switch1" || updatedItem.name == "switch2") {
-      // rebuild with new switch setting
-      newBoardID = _state.data["boardPreset"];  // run in sveltekit task
+      // Rebuild pins with new switch settings
+      EXT_LOGD(MB_TAG, "switch changed - rebuilding board defaults");
+      newBoardID = _state.data["boardPreset"];
     } else if (updatedItem.name == "maxPower") {
+      // Manual maxPower change = user is customizing
       newState["modded"] = true;
-    } else if (updatedItem.name == "usage" || updatedItem.name == "index") {  // usage / index of any of the pins
+    } else if (updatedItem.name == "usage" || updatedItem.name == "index") {
+      // Manual pin usage change = user is customizing
       newState["modded"] = true;
     } else if (updatedItem.name == "i2cFreq") {
-      Wire.setClock(updatedItem.value.as<uint32_t>() * 1000);  // uint32_t instead of uint16_t to multiply in 32-bit arithmetic
+      Wire.setClock(updatedItem.value.as<uint32_t>() * 1000);
     }
 
-    if (newState.size()) update(newState, ModuleState::update, _moduleName);  // if changes made then update
+    if (newState.size()) {
+      update(newState, ModuleState::update, _moduleName);
+    }
   }
 
   // Function to convert drive capability to string
@@ -723,26 +734,35 @@ class ModuleIO : public Module {
     }
   }
 
-  bool _initialPinReadDone = false;
+  bool _initialUpdateDone = false;
 
   void loop20ms() override {
     // run in sveltekit task
     Module::loop20ms();
 
-    // update board presets
+    // Update board presets
     if (newBoardID != UINT8_MAX) {
-      setBoardPresetDefaults(newBoardID);  // run from sveltekit task
+      setBoardPresetDefaults(newBoardID);
       newBoardID = UINT8_MAX;
-      _initialPinReadDone = true;
+      _initialUpdateDone = true;
     }
 
-    // during boot, the IO module is unchanged, not triggering updates, so need to do it manually
-    if (!_initialPinReadDone) {
-      callUpdateHandlers(_moduleName);  // calls readPins for all subscribed handlers
-      _initialPinReadDone = true;
+    // During boot, handle boardPreset from file if modded=false
+    // This runs AFTER file load completes and all values (including modded) are restored
+    if (!_initialUpdateDone) {
+      if (_state.data["modded"] == false) {
+        uint8_t boardPreset = _state.data["boardPreset"];
+        EXT_LOGD(MB_TAG, "Applying board preset %d defaults from file (modded=false)", boardPreset);
+        newBoardID = boardPreset;
+        // Will be processed in next loop20ms iteration at top, setting _initialUpdateDone
+      } else {
+        EXT_LOGD(MB_TAG, "Skipping board preset defaults - using custom pins from file (modded=true)");
+        callUpdateHandlers(_moduleName);
+        _initialUpdateDone = true;
+      }
     }
 
-    // update I2C devices
+    // Update I2C devices
     if (_triggerUpdateI2C != UINT8_MAX) {
       _updateI2CDevices();
       _triggerUpdateI2C = UINT8_MAX;

platformio.ini

@@ -259,7 +259,8 @@ class NodeManager : public Module {
         // EXT_LOGD(ML_TAG, "handle %s[%d]%s[%d].%s = %s -> %s", updatedItem.parent[0].c_str(), updatedItem.index[0], updatedItem.parent[1].c_str(), updatedItem.index[1], updatedItem.name.c_str(),
         // updatedItem.oldValue.c_str(), updatedItem.value.as<String>().c_str());
         if (updatedItem.index[0] < nodes->size()) {
-          EXT_LOGD(ML_TAG, "%s on: %s (#%d)", nodeState["name"].as<const char*>(), updatedItem.value.as<String>().c_str(), nodes->size());
+          const char* name = nodeState["name"];
+          EXT_LOGD(ML_TAG, "%s on: %s (#%d)", name ? name : "", updatedItem.value.as<String>().c_str(), nodes->size());
           Node* nodeClass = (*nodes)[updatedItem.index[0]];
           if (nodeClass != nullptr) {
             nodeClass->on = updatedItem.value.as<bool>();  // set nodeclass on/off
@@ -269,7 +270,7 @@ class NodeManager : public Module {
             xSemaphoreGive(*nodeClass->layerMutex);
             nodeClass->requestMappings();
           } else
-            EXT_LOGW(ML_TAG, "Nodeclass %s not found", nodeState["name"].as<const char*>());
+            EXT_LOGW(ML_TAG, "Nodeclass %s not found", name ? name : "");
         }
       }  // nodes[i].on
 
@@ -287,8 +288,10 @@ class NodeManager : public Module {
             xSemaphoreGive(*nodeClass->layerMutex);
 
             nodeClass->requestMappings();
-          } else
-            EXT_LOGW(ML_TAG, "nodeClass not found %s", nodeState["name"].as<const char*>());
+          } else {
+            const char* name = nodeState["name"];
+            EXT_LOGW(ML_TAG, "nodeClass not found %s", name ? name : "");
+          }
         }
 
       }  // nodes[i].controls[j].value

src/MoonBase/Modules/ModuleIO.h

@@ -338,7 +338,7 @@ class ModuleLightsControl : public Module {
       };
       layerP.lights.header.brightness = newBri;
     } else if (updatedItem.name == "palette") {
-      const size_t nrOfPaletteEntries = sizeof(layerP.palette.entries) / sizeof(CRGB);
+      // const size_t nrOfPaletteEntries = sizeof(layerP.palette.entries) / sizeof(CRGB);
       layerP.palette = getGradientPalette(updatedItem.value);
     } else if (updatedItem.name == "preset") {
       // copy /.config/effects.json to the hidden folder /.config/presets/preset[x].json