From b72b5db5878e955db8c35089a87a6cf1249f0482 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 30 Jun 2026 10:37:49 +0900 Subject: [PATCH 1/4] better nil handling --- lua/wikis/commons/TeamTemplate.lua | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lua/wikis/commons/TeamTemplate.lua b/lua/wikis/commons/TeamTemplate.lua index fea51c9a51b..47a27c82d5b 100644 --- a/lua/wikis/commons/TeamTemplate.lua +++ b/lua/wikis/commons/TeamTemplate.lua @@ -84,10 +84,14 @@ end Same as TeamTemplate.getRaw, except that it returns nil if the team template does not exist. ]] ----@param team string +---@param team string? ---@param date string|number? ---@return teamTemplateData? function TeamTemplate.getRawOrNil(team, date) + if Logic.isEmpty(team) then + return + end + ---@cast team -nil team = team:gsub('_', ' '):lower() -- return mw.ext.TeamTemplate.raw(team, date) From abe71d01599b62ee14cdbf64decaea027b618e5f Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 30 Jun 2026 10:43:23 +0900 Subject: [PATCH 2/4] just throw instead --- lua/wikis/commons/TeamTemplate.lua | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lua/wikis/commons/TeamTemplate.lua b/lua/wikis/commons/TeamTemplate.lua index 47a27c82d5b..9a2f4902e5a 100644 --- a/lua/wikis/commons/TeamTemplate.lua +++ b/lua/wikis/commons/TeamTemplate.lua @@ -83,15 +83,14 @@ end --[[ Same as TeamTemplate.getRaw, except that it returns nil if the team template does not exist. + +Throws if `team` is nil. ]] ---@param team string? ---@param date string|number? ---@return teamTemplateData? function TeamTemplate.getRawOrNil(team, date) - if Logic.isEmpty(team) then - return - end - ---@cast team -nil + assert(team ~= nil, 'TeamTemplate.getRawOrNil: \'team\' must not be nil') team = team:gsub('_', ' '):lower() -- return mw.ext.TeamTemplate.raw(team, date) From c4a3df10496134650f48dc774e609bd28c275056 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Tue, 30 Jun 2026 10:47:39 +0900 Subject: [PATCH 3/4] markdown in docs --- lua/wikis/commons/TeamTemplate.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/wikis/commons/TeamTemplate.lua b/lua/wikis/commons/TeamTemplate.lua index 9a2f4902e5a..7b6b96b8834 100644 --- a/lua/wikis/commons/TeamTemplate.lua +++ b/lua/wikis/commons/TeamTemplate.lua @@ -84,7 +84,7 @@ end Same as TeamTemplate.getRaw, except that it returns nil if the team template does not exist. -Throws if `team` is nil. +Throws if `team` is `nil`. ]] ---@param team string? ---@param date string|number? From a91eb2d366b808adf60307fd8184243d9ad3ada1 Mon Sep 17 00:00:00 2001 From: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com> Date: Fri, 3 Jul 2026 09:06:21 +0900 Subject: [PATCH 4/4] adjust type annotation --- lua/wikis/commons/TeamTemplate.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/wikis/commons/TeamTemplate.lua b/lua/wikis/commons/TeamTemplate.lua index 7b6b96b8834..4d340a4046e 100644 --- a/lua/wikis/commons/TeamTemplate.lua +++ b/lua/wikis/commons/TeamTemplate.lua @@ -86,7 +86,7 @@ does not exist. Throws if `team` is `nil`. ]] ----@param team string? +---@param team string ---@param date string|number? ---@return teamTemplateData? function TeamTemplate.getRawOrNil(team, date)