Commit 04d8711
committed
fix(Sign): restore visibleElements check in needCreateSignature to avoid blocking clickToSign
The commit e9ea794 changed needCreateSignature to return true for any
signer with a signRequestId, without checking whether visual elements
were placed. This caused the 'Sign the document.' button to be hidden
in clickToSign scenarios, because the 'Define your signature' prompt
was shown instead.
The signerHasSignRequest flag is already passed to the validator in
confirmSignDocument and executeSigningAction, so the drawing prompt
is triggered at action time when appropriate (e.g. GRAPHIC_ONLY mode).
The upfront needCreateSignature computed should only block the sign
button when there are placed visible elements for this signer.
Fixes E2E tests: multi-signer-sequential, sign-email-token-unauthenticated,
sign-herself-with-click-to-sign
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>1 parent 01e0c67 commit 04d8711
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
277 | 281 | | |
278 | 282 | | |
279 | 283 | | |
| |||
0 commit comments