Skip to content

Commit 4b28e64

Browse files
authored
Refactor and fix UnityVersion __getitem__ (#365)
* refactor UnityVersion __getitem__
1 parent 5aa855a commit 4b28e64

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

UnityPy/helpers/UnityVersion.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -77,18 +77,15 @@ def from_str(cls, version: str):
7777
def __repr__(self) -> str:
7878
return f"UnityVersion {self.major}.{self.minor}{self.type_str}{self.type_number}"
7979

80-
def __getitem__(self, idx: int) -> int:
81-
if idx == 0:
82-
return self.major
83-
elif idx == 1:
84-
return self.minor
85-
elif idx == 2:
86-
return self.build
87-
elif idx == 3:
88-
return self.type.value
89-
elif idx == 4:
90-
return self.type_number
91-
raise IndexError("Invalid UnityVersion index")
80+
def __getitem__(self, idx: Union[int, slice]) -> Union[int, Tuple[int, ...]]:
81+
values = (
82+
self.major,
83+
self.minor,
84+
self.build,
85+
self.type.value,
86+
self.type_number,
87+
)
88+
return values[idx]
9289

9390
def as_tuple(self) -> Tuple[int, int, int, int, int]:
9491
return (self.major, self.minor, self.build, self.type.value, self.type_number)

0 commit comments

Comments
 (0)