From 24eee2afde9a1f72a20ddfa1adb3a5a50d4bd051 Mon Sep 17 00:00:00 2001
From: Goooler <wangzongler@gmail.com>
Date: Fri, 24 Jul 2026 17:24:12 +0800
Subject: [PATCH] Deprecate minimizeJar property

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---
 docs/changes/README.md                        |  2 ++
 .../gradle/plugins/shadow/tasks/ShadowJar.kt  | 23 ++++++++++++-------
 .../plugins/shadow/ShadowPropertiesTest.kt    |  2 +-
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/docs/changes/README.md b/docs/changes/README.md
index 636570571..1a004aeb8 100644
--- a/docs/changes/README.md
+++ b/docs/changes/README.md
@@ -10,6 +10,8 @@
 ### Deprecated
 
 - Deprecate `keepRules` and `keepRuleFiles` in `R8Spec`. ([#2120](https://github.com/GradleUp/shadow/pull/2120))
+- Deprecate `ShadowJar.minimizeJar`; call `ShadowJar.minimize()` explicitly instead. ([#2124](https://github.com/GradleUp/shadow/pull/2124))  
+  The property will be made non-public in Shadow 10.
 
 ## [9.6.1](https://github.com/GradleUp/shadow/releases/tag/9.6.1) - 2026-07-22
 
diff --git a/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt b/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
index 469c54ec7..84f406211 100644
--- a/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
+++ b/src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt
@@ -103,6 +103,10 @@ public abstract class ShadowJar : Jar() {
    *
    * Defaults to `false`.
    */
+  @Deprecated(
+    message = "Use `minimize()` instead. This property will be made non-public in Shadow 10.",
+    replaceWith = ReplaceWith("minimize()"),
+  )
   @get:Input
   @get:Option(
     option = "minimize-jar",
@@ -115,20 +119,20 @@ public abstract class ShadowJar : Jar() {
 
   @get:Classpath
   public open val toMinimize: ConfigurableFileCollection = objectFactory.fileCollection {
-    minimizeJar.map {
+    _minimizeJar.map {
       if (it) (defaultMinimizeSpec.resolve(configurations.get()) - apiJars) else emptySet()
     }
   }
 
   @get:Classpath
   public open val apiJars: ConfigurableFileCollection = objectFactory.fileCollection {
-    minimizeJar.map { if (it) project.getApiJars() else emptySet<File>() }
+    _minimizeJar.map { if (it) project.getApiJars() else emptySet<File>() }
   }
 
   @get:InputFiles
   @get:PathSensitive(PathSensitivity.RELATIVE)
   public open val sourceSetsClassesDirs: ConfigurableFileCollection = objectFactory.fileCollection {
-    minimizeJar.map {
+    _minimizeJar.map {
       if (it) {
         project.sourceSets.map { sourceSet ->
           sourceSet.output.classesDirs.filter(File::isDirectory)
@@ -141,7 +145,7 @@ public abstract class ShadowJar : Jar() {
 
   @get:Classpath
   public open val r8Classpath: ConfigurableFileCollection = objectFactory.fileCollection {
-    minimizeJar.zip(minimizeSpec.tool) { enabled, tool ->
+    _minimizeJar.zip(minimizeSpec.tool) { enabled, tool ->
       if (enabled && tool == MinimizeTool.R8) {
         // Use findByName so custom ShadowJar tasks can be configured even when shadowR8 isn't
         // registered.
@@ -331,10 +335,10 @@ public abstract class ShadowJar : Jar() {
 
   @get:Inject protected abstract val archiveOperations: ArchiveOperations
 
-  /** Enable [minimizeJar] and execute the [action] with the [MinimizeSpec] for minimize. */
+  /** Enable minimization and execute the [action] with the [MinimizeSpec] for minimize. */
   @JvmOverloads
   public open fun minimize(action: Action<in MinimizeSpec> = Action {}) {
-    minimizeJar.set(true)
+    _minimizeJar.set(true)
     action.execute(minimizeSpec)
   }
 
@@ -531,7 +535,7 @@ public abstract class ShadowJar : Jar() {
       }
     }
     val unusedClasses =
-      if (minimizeJar.get() && minimizeSpec.tool.get() == MinimizeTool.DEPENDENCY_ANALYZER) {
+      if (_minimizeJar.get() && minimizeSpec.tool.get() == MinimizeTool.DEPENDENCY_ANALYZER) {
         val unusedTracker =
           UnusedTracker(
             sourceSetsClassesDirs = sourceSetsClassesDirs.files,
@@ -578,6 +582,9 @@ public abstract class ShadowJar : Jar() {
     transformers.add(transformer)
   }
 
+  private val _minimizeJar
+    get() = @Suppress("DEPRECATION") minimizeJar
+
   private val packageRelocators: List<SimpleRelocator>
     get() {
       if (enableAutoRelocation.get()) {
@@ -702,7 +709,7 @@ public abstract class ShadowJar : Jar() {
   }
 
   private fun minimizeWithR8() {
-    val useR8 = minimizeJar.get() && minimizeSpec.tool.get() == MinimizeTool.R8
+    val useR8 = _minimizeJar.get() && minimizeSpec.tool.get() == MinimizeTool.R8
     if (!useR8) return
     val keptDependencyFiles = includedDependencies.files - toMinimize.files
     R8Minimizer(
diff --git a/src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt b/src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt
index 7ce1be2f8..f3c94aa9a 100644
--- a/src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt
+++ b/src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt
@@ -150,7 +150,7 @@ class ShadowPropertiesTest {
         assertThat(enableAutoRelocation.get()).isFalse()
         @Suppress("DEPRECATION") assertThat(enableKotlinModuleRemapping.get()).isTrue()
         assertThat(failOnDuplicateEntries.get()).isFalse()
-        assertThat(minimizeJar.get()).isFalse()
+        @Suppress("DEPRECATION") assertThat(minimizeJar.get()).isFalse()
         assertThat(mainClass.orNull).isNull()
         assertThat(javaLauncher.get().metadata.jvmVersion)
           .isEqualTo(