Skip to content

Fix Webcam css #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abigailalexander merged 3 commits into from
May 29, 2026
Merged

Fix Webcam css #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
946770b
Scope webcam css just to webcam widget
abigailalexander May 29, 2026
9f0133f
Reapply settings to image
abigailalexander May 29, 2026
4bcfea7
Update tests
abigailalexander May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/ui/widgets/Image/image.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.Image {
max-width: 100%;
min-width:100%;
min-height: 100%;
width: 100%;
height: 100%;
object-fit: contain;
overflow: hidden;
}
2 changes: 2 additions & 0 deletions src/ui/widgets/Image/image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
ColorPropOpt
} from "../propTypes";
import { registerWidget } from "../register";
import classes from "./image.module.css";
import { Box } from "@mui/material";

const widgetName = "image";
Expand Down Expand Up @@ -86,6 +87,7 @@ export const ImageComponent = (
return (
<Box sx={fullStyle} onClick={onClick}>
<img
className={classes.Image}
src={imageFileName}
alt={props.alt || undefined}
style={{
Expand Down
6 changes: 6 additions & 0 deletions src/ui/widgets/Symbol/__snapshots__/symbol.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`<Symbol /> from .bob file > matches snapshot (using fallback symbol) 1`
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 1.gif"
style="display: block; transform: rotate(0deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand All @@ -19,6 +20,7 @@ exports[`<Symbol /> from .bob file > matches snapshot (with index) 1`] = `
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 3.svg"
style="display: block; transform: rotate(0deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand All @@ -32,6 +34,7 @@ exports[`<Symbol /> from .bob file > matches snapshot (with rotation) 1`] = `
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 1.gif"
style="display: block; transform: rotate(45deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand All @@ -45,6 +48,7 @@ exports[`<Symbol /> from .bob file > matches snapshot (without index) 1`] = `
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 1.gif"
style="display: block; transform: rotate(0deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand All @@ -58,6 +62,7 @@ exports[`<Symbol /> from .opi file > matches snapshot (with rotation) 1`] = `
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 1.gif"
style="display: block; transform: rotate(45deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand All @@ -71,6 +76,7 @@ exports[`<Symbol /> from .opi file > matches snapshot 1`] = `
class="MuiBox-root css-lj78bd"
>
<img
class="_Image_171889"
src="img 1.gif"
style="display: block; transform: rotate(0deg) scaleX(1) scaleY(1); object-fit: contain; object-position: top left; opacity: 1;"
/>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/widgets/Webcam/webcam.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
img {
.Webcam {
max-width: 100%;
min-width:100%;
min-height: 100%;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/widgets/Webcam/webcam.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const WebcamComponent = (
>
<img
id={props.name}
className={classes.img}
className={classes.Webcam}
src={props.url}
alt={`Loading Webcam MJPEG stream...`}
onError={onError}
Expand Down
Loading