feat: Update sampling config. Remove SamplingSettings and use hardcoded values for simplification.

Author: whatevertogo

MCPForUnity/Editor/ActionTrace/Capture/Sampling/SamplingConfig.cs

@@ -7,28 +7,53 @@ namespace MCPForUnity.Editor.ActionTrace.Capture
     /// <summary>
     /// Static configuration for sampling strategies.
     /// Event types can be registered with their desired sampling behavior.
+    ///
+    /// Sampling intervals are configured via hardcoded constants.
+    /// To customize sampling behavior, modify InitializeStrategies() directly.
     /// </summary>
     public static class SamplingConfig
     {
+        // Hardcoded sampling intervals (milliseconds)
+        private const int HierarchySamplingMs = 1000;
+        private const int SelectionSamplingMs = 500;
+        private const int PropertySamplingMs = 200;
+
         /// <summary>
         /// Default sampling strategies for common event types.
         /// Configured to prevent event floods while preserving important data.
         /// Thread-safe: uses ConcurrentDictionary to prevent race conditions
         /// when accessed from EditorApplication.update and event emitters simultaneously.
         /// </summary>
         public static readonly ConcurrentDictionary<string, SamplingStrategy> Strategies = new(
-            new Dictionary<string, SamplingStrategy>
+            InitializeStrategies()
+        );
+
+        /// <summary>
+        /// Initializes sampling strategies with hardcoded values.
+        /// </summary>
+        private static Dictionary<string, SamplingStrategy> InitializeStrategies()
+        {
+            return new Dictionary<string, SamplingStrategy>
             {
                 // Hierarchy changes: Throttle to 1 event per second
                 {
                     EventTypes.HierarchyChanged,
-                    new SamplingStrategy(SamplingMode.Throttle, 1000)
+                    new SamplingStrategy(SamplingMode.Throttle, HierarchySamplingMs)
                 },
 
-                // PropertyModified handling removed here to avoid double-debounce when
-                // PropertyChangeTracker already implements a dedicated debounce window.
-                // If desired, SamplingConfig.SetStrategy(EventTypes.PropertyModified, ...) can
-                // be used at runtime to re-enable middleware-level sampling.
+                // Selection changes: Throttle to 1 event per 500ms
+                {
+                    EventTypes.SelectionChanged,
+                    new SamplingStrategy(SamplingMode.Throttle, SelectionSamplingMs)
+                },
+
+                // Property modifications: Debounce by key (200ms window)
+                // Note: PropertyChangeTracker also implements its own debounce window,
+                // so this provides additional protection against event storms.
+                {
+                    EventTypes.PropertyModified,
+                    new SamplingStrategy(SamplingMode.DebounceByKey, PropertySamplingMs)
+                },
 
                 // Component/GameObject events: No sampling (always record)
                 // ComponentAdded, ComponentRemoved, GameObjectCreated, GameObjectDestroyed
@@ -42,8 +67,8 @@ public static class SamplingConfig
 
                 // Build events: No sampling (record all)
                 // BuildStarted, BuildCompleted, BuildFailed are not in this dictionary
-            }
-        );
+            };
+        }
 
         /// <summary>
         /// Adds or updates a sampling strategy for an event type.

MCPForUnity/Editor/ActionTrace/Core/Settings/ActionTraceSettings.cs

@@ -59,7 +59,7 @@ public sealed class StorageSettings
         public int MaxEvents = 800;
 
         [Range(10, 1000)]
-        [Tooltip("Number of hot events (10-1000) to retain with full payload. Older events will be dehydrated (Payload=null).")]
+        [Tooltip("Number of hot events (10-1000) to retain with full payload. Events are kept in sequence order; the first N events (oldest) have full payload, while events beyond this limit are dehydrated (Payload=null).")]
         public int HotEventCount = 150;
 
         [Tooltip("Minimum number of events to keep when auto-cleaning.")]
@@ -72,28 +72,18 @@ public sealed class StorageSettings
         public int AutoSaveIntervalSeconds = 30;
     }
 
-    /// <summary>
-    /// Layered settings for sampling and throttling.
-    /// Controls how high-frequency events are sampled.
-    /// </summary>
-    [Serializable]
-    public sealed class SamplingSettings
-    {
-        [Tooltip("Enable global sampling. Events below threshold will be sampled.")]
-        public bool EnableSampling = true;
-
-        [Tooltip("Sampling importance threshold. Events below this value may be sampled.")]
-        public float SamplingImportanceThreshold = 0.3f;
-
-        [Tooltip("HierarchyChanged event sampling interval (milliseconds).")]
-        public int HierarchySamplingMs = 1000;
-
-        [Tooltip("SelectionChanged event sampling interval (milliseconds).")]
-        public int SelectionSamplingMs = 500;
-
-        [Tooltip("PropertyModified event sampling interval (milliseconds).")]
-        public int PropertySamplingMs = 200;
-    }
+    // SamplingSettings is deprecated. Sampling is now configured via SamplingConfig
+    // with hardcoded values to avoid runtime configuration complexity.
+    //
+    // [Serializable]
+    // public sealed class SamplingSettings
+    // {
+    //     public bool EnableSampling = true;
+    //     public float SamplingImportanceThreshold = 0.3f;
+    //     public int HierarchySamplingMs = 1000;
+    //     public int SelectionSamplingMs = 500;
+    //     public int PropertySamplingMs = 200;
+    // }
 
     /// <summary>
     /// Persistent settings for the ActionTrace system.
@@ -120,9 +110,9 @@ public sealed class ActionTraceSettings : ScriptableObject
         [Tooltip("Controls event storage limits and memory management")]
         public StorageSettings Storage = new();
 
-        [Header("Event Sampling")]
-        [Tooltip("Controls high-frequency event sampling to prevent event storms")]
-        public SamplingSettings Sampling = new();
+        // Sampling is configured via SamplingConfig with hardcoded values
+        // To customize, modify SamplingConfig.InitializeStrategies() directly
+        // public SamplingSettings Sampling = new();
 
         // ========== Runtime State ==========