How to call GlobalScript functions

[THEkatinamicrowave]

I defined public function removeBNWShader() { ... } in data/global.hx, but I can't figure out how to call it. I've tried GlobalScript.call("removeBNWShader") but nothing happens. It doesn't trace an error either. I've also tried GlobalScript.scripts.call("removeBNWShader") to get around the function but that obviously didn't work either. I've imported GlobalScript from funkin.backend.scripting.GlobalScript as well so it's not an issue with HScript not knowing what to do with it.

[THEkatinamicrowave]

Here's some more images for context:

[r6915ee]

You need to remove the public access modifier from the function in order for the call method to recognize it.

[THEkatinamicrowave]

I removed the public access modifier, but it still isn't calling properly. In fact, I've found that even when I reload the GlobalScript it still doesn't do the thing correctly. Here are some images

At this point, I was going to question whether removeShader was even working, but the shader does get removed on preStateSwitch when I switch mods, which wouldn't happen if removeBNWShader was broken.

[r6915ee]

I removed the public access modifier, but it still isn't calling properly. In fact, I've found that even when I reload the GlobalScript it still doesn't do the thing correctly. Here are some images

The tracing is working in this image, so the function is being called, unless I'm misunderstanding something. Also, what would you need GlobalScript.onModSwitch for?

[THEkatinamicrowave]

onModSwitch just so happens to reload the GlobalScript so that I don't have to reload the entire mod between tests. Also, yes. The trace is being called, but--for whatever dumb reason, the shader isn't being removed. Not sure what to make of this.

Here; I'll directly paste my code into the chat so that it can be tested and perchance be figured out.

---

data/global.hx:

//
var blackAndWhite:CustomShader;

function new() {
	blackAndWhite = new CustomShader("BlackAndWhite");
}

function preStateSwitch() {
	removeBNWShader();
}

function postStateSwitch() {
	addBNWShader();
}

function addBNWShader() {
	FlxG.game.addShader(blackAndWhite);
	trace('love yourself 🌹');
}

function removeBNWShader() {
	FlxG.game.removeShader(blackAndWhite);
	trace("kill yourself 🌩️");
}

data/stages/stage.hx:

//
function postCreate() {
	trace("yep this line should remove the shader");
	GlobalScript.call("removeBNWShader");
}

shaders/BlackAndWhite.frag:

#pragma header

mat4 greyscaleMatrix() {
	vec3 lum = vec3(0.2126, 0.7152, 0.0722);

	return mat4(
		lum.x, lum.y, lum.z, 0,
		lum.x, lum.y, lum.z, 0,
		lum.x, lum.y, lum.z, 0,
		0, 0, 0, 1
	);
}

void main() {
	vec4 col = flixel_texture2D(bitmap, openfl_TextureCoordv);
	vec4 blackAndWhite = col;

	blackAndWhite = blackAndWhite * greyscaleMatrix();
	gl_FragColor = blackAndWhite;
}

---

these are all the files related to turning the shader on and off. BTW my Codename is on v1.0.1 and I've not downloaded anything from the Actions tab.

[r6915ee]

Then you should swap out the state switch callbacks with the destroy callback and change the new callback like so:

function new() {
    blackAndWhite = new CustomShader("BlackAndWhite");
    addBNWShader();
}

function destroy() removeBNWShader();

In the stage script, you will additionally need to add the following to readd the shader upon exiting the song:

function destroy() GlobalScript.call("addBNWShader");

[THEkatinamicrowave]

Thank you! I totally forgot about Global destroy(). This helped a lot!