Skip to content

Fix dropdown hover border radius #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashified wants to merge 4 commits into
base: staging
Choose a base branch
from
+22 −20
Open

Fix dropdown hover border radius #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78ca6da
Fix dropdown hover border radius
shashified May 19, 2026
5f1db7f
fixed hover issue
shashified May 19, 2026
84afafc
Merge branch 'CodeChefVIT:staging' into staging
shashified May 19, 2026
c92a721
Fix dropdown hover radius alignment
shashified May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/components/FloatingNavbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default function FloatingNavbar({ onNavigate }: Props) {
</DropdownMenuTrigger>

<DropdownMenuContent
className="xl:hidden mt-2 py-2 w-72 space-y-1 rounded-3xl
className="xl:hidden mt-2 py-2 w-72 space-y-1 rounded-[22px]
border border-[#3A3745] shadow-lg backdrop-blur-sm transition-colors
bg-[#e8e9ff] text-gray-700
dark:bg-black dark:text-white dark:border-[#3A3745]"
Expand All @@ -53,7 +53,7 @@ export default function FloatingNavbar({ onNavigate }: Props) {
<Link
href={pathname === "/upload" ? "/" : "/upload"}
onClick={() => onNavigate()}
className="flex w-full items-center gap-3 rounded-lg px-3 py-1 hover:bg-[#1A1823] transition"
className="flex w-full items-center gap-3 rounded-md px-3 py-1 hover:bg-[#1A1823] transition"
>
<UploadIcon className="h-4 w-4" />
<span className="text-sm font-medium">
Expand All @@ -62,18 +62,20 @@ export default function FloatingNavbar({ onNavigate }: Props) {
</Link>
</DropdownMenuItem>

<DropdownMenuItem asChild onSelect={(e) => e.preventDefault()}>
<div className="flex w-full items-center gap-3 rounded-lg px-3 py-1 hover:bg-[#1A1823] transition">
<PinnedModal/>
</div>
</DropdownMenuItem>
<DropdownMenuItem
onSelect={(e) => e.preventDefault()}
className="mx-1 my-1 hover:bg-[#1F2A3D]"
>
<PinnedModal />
</DropdownMenuItem>

<DropdownMenuItem asChild onSelect={(e) => e.preventDefault()}>
<div className="flex w-full items-center gap-3 rounded-lg px-3 py-1 hover:bg-[#1A1823] transition">
<RequestModal/>
</div>
</DropdownMenuItem>
<div className="flex w-full items-center gap-3 rounded-lg px-3 py-1">
<DropdownMenuItem
onSelect={(e) => e.preventDefault()}
className="mx-1 my-1 hover:bg-[#1F2A3D]"
>
<RequestModal />
</DropdownMenuItem>
<div className="flex h-full w-full items-center gap-3 rounded-md">
<div className="border rounded-full">
<ModeToggle />
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/ui/PinnedModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const SortableItem = ({
ref={setNodeRef}
style={style}
{...attributes}
className={`mb-2 flex items-center justify-between rounded-md border border-[#3A3745] px-4 py-2 pl-2 shadow-sm ${
className={`mb-2 flex items-center justify-between rounded-2xl border border-[#3A3745] px-2 py-1 pl-2 shadow-sm ${
isDragging ? "scale-[1.02] cursor-grabbing opacity-90" : "cursor-grab"
}`}
>
Expand Down Expand Up @@ -180,7 +180,7 @@ const PinnedModal = ({
}}
>
{page === "Navbar" ? (
<DialogTrigger className="flex h-full w-full flex-row items-center gap-2">
<DialogTrigger className="flex h-full w-full flex-row items-center gap-2 rounded-xl px-2 py-2 hover:bg-[#1A2333] transition-all duration-200">
<Pin size={16} />
{triggerName}
</DialogTrigger>
Expand All @@ -206,7 +206,7 @@ const PinnedModal = ({
</div>
</div>
<div className="mt-4">
<div className="h-64 w-full overflow-y-auto rounded-md border border-[#3A3745] p-2">
<div className="h-64 w-full overflow-y-auto rounded-sm border border-[#3A3745] p-2">
{displayPapers.length > 0 ? (
<DndContext
sensors={sensors}
Expand Down
8 changes: 4 additions & 4 deletions src/components/ui/dropdown-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ const DropdownMenuItem = React.forwardRef<
<DropdownMenuPrimitive.Item
ref={ref}
className={cn(
"relative flex cursor-default select-none items-center gap-2 rounded-sm px-2 py-1.5 text-sm outline-none transition-colors focus:bg-accent focus:text-accent-foreground data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&>svg]:size-4 [&>svg]:shrink-0",
inset && "pl-8",
className,
)}
"relative flex cursor-default select-none items-center gap-2 rounded-xl px-2 py-1.5 text-sm outline-none transition-colors hover:bg-[#1F2A3D] focus:bg-[#1F2A3D] text-white data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&>svg]:size-4 [&>svg]:shrink-0",
inset && "pl-8",
className,
)}
{...props}
/>
));
Expand Down