Skip to content

Commit ab84893

Browse files
committed
silenting false positives in O2linter with disable directive, part 1
1 parent 7d886c0 commit ab84893

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

PWGCF/MultiparticleCorrelations/Core/MuPa-DataMembers.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ struct TaskConfiguration {
8686
// || es.fCalculateEtaSeparationsAsFunctionOf[AFO_PT]
8787
bool fCalculate2DAsFunctionOf[eAsFunctionOf2D_N] = {false}; //! See example above for 1D case + enum for 2D details
8888
bool fCalculate3DAsFunctionOf[eAsFunctionOf3D_N] = {false}; //! See example above for 1D case + enum for 3D details
89-
TDatabasePDG* fDatabasePDG = NULL; // booked only when MC info is available. There is a standard memory blow-up when booked, therefore I need to request also fUseDatabasePDG = true
89+
TDatabasePDG* fDatabasePDG = NULL; // o2-linter: disable=pdg/database
90+
// booked only when MC info is available. There is a standard memory blow-up when booked, therefore I need to request also fUseDatabasePDG = true
9091
// TBI 20250625 replace eventually with the service O2DatabasePDG, when memory consumption problem is resolved
9192
bool fUseSetBinLabel = false; // until SetBinLabel(...) large memory consumption is resolved, do not use hist->SetBinLabel(...), see ROOT Forum
9293
// See also local executable PostprocessLabels.C

PWGCF/MultiparticleCorrelations/Core/MuPa-MemberFunctions.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1821,9 +1821,9 @@ void defaultBinning()
18211821
ph.fParticleHistogramsBins[edcaZ][1] = -10.;
18221822
ph.fParticleHistogramsBins[edcaZ][2] = 10.;
18231823

1824-
ph.fParticleHistogramsBins[ePDG][0] = 2000;
1825-
ph.fParticleHistogramsBins[ePDG][1] = -1000.;
1826-
ph.fParticleHistogramsBins[ePDG][2] = 1000.;
1824+
ph.fParticleHistogramsBins[ePDG][0] = 2000; // o2-linter: disable=pdg/explicit-code
1825+
ph.fParticleHistogramsBins[ePDG][1] = -1000.; // o2-linter: disable=pdg/explicit-code
1826+
ph.fParticleHistogramsBins[ePDG][2] = 1000.; // o2-linter: disable=pdg/explicit-code
18271827

18281828
// c) Default binning for particle histograms 2D:
18291829
// At the moment, for fixed binning, I just re-use the binning of corresponding 1D histograms.
@@ -8276,7 +8276,8 @@ void bookTheRest()
82768276

82778277
// b) Book TDatabasePDG:
82788278
if (tc.fUseDatabasePDG) {
8279-
tc.fDatabasePDG = new TDatabasePDG(); // there is a standard memory blow-up here
8279+
// Remark: there is a standard memory blow-up here TBI 20260714 switch eventualy to o2::framework::O2DatabasePDG when lazy initialization is provided
8280+
tc.fDatabasePDG = new TDatabasePDG(); // o2-linter: disable=pdg/database
82808281
}
82818282

82828283
if (tc.fVerbose) {

PWGCF/MultiparticleCorrelations/Tasks/multiparticle-correlations-ab.cxx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ using TracksRecQA = TracksRec; // if I would need additional tables for QA, j
7979

8080
// *) ROOT include headers and namespaces:
8181
#include <TComplex.h>
82-
#include <TDatabasePDG.h>
82+
// TBI 20260714 switch eventualy to o2::framework::O2DatabasePDG when lazy initialization is provided
83+
#include <TDatabasePDG.h> // o2-linter: disable=pdg/database
8384
#include <TExMap.h>
8485
#include <TF1.h>
8586
#include <TF3.h>

0 commit comments

Comments
 (0)